Fixed tests

Author: forman

chartlets.py/chartlets/util/assertions.py

@@ -22,4 +22,4 @@ def assert_is_none(name: str, value: Any):
 
 def assert_is_given(name: str, value: Any):
     if not value:
-        raise TypeError(f"value for {name!r} must be given")
+        raise ValueError(f"value for {name!r} must be given")

chartlets.py/tests/channel_test.py

@@ -12,7 +12,7 @@ class ChannelTest(unittest.TestCase):
         link_name: str
 
         def test_no_args_given(self):
-            with pytest.raises(ValueError, match="value for 'id' must be given and must not be empty"):
+            with pytest.raises(ValueError, match="value for 'id' must be given"):
                 obj = self.channel_cls()
 
         def test_id_given(self):
@@ -29,14 +29,14 @@ def test_app_ok(self):
 
         def test_container_with_id(self):
             with pytest.raises(
-                TypeError,
-                match="value of 'id' must be None, but was 'test_id'",
+                ValueError,
+                match="value for 'property' must be given",
             ):
                 self.channel_cls("test_id", **{self.link_name: "container"})
 
         def test_app_no_prop(self):
             with pytest.raises(
-                TypeError,
+                ValueError,
                 match="value for 'property' must be given",
             ):
                 self.channel_cls(**{self.link_name: "app"})
@@ -45,15 +45,14 @@ def test_wrong_link(self):
             with pytest.raises(
                 ValueError,
                 match=(
-                    f"value of '{self.link_name}' must be one of"
-                    f" \\('component', 'container', 'app', None\\),"
-                    f" but was 'host'"
+                    f"value of {self.link_name!r} must be one of"
+                    r" \('container', 'app'\), but was 'host'"
                 ),
             ):
                 self.channel_cls(**{self.link_name: "host"})
 
         def test_no_trigger(self):
-            obj = self.channel_cls()
+            obj = self.channel_cls("some_id")
             if isinstance(obj, State):
                 self.assertTrue(obj.no_trigger)
             else:
@@ -88,6 +87,10 @@ class InputTest(make_base(), unittest.TestCase):
     channel_cls = Input
     link_name = "source"
 
+    def test_disallow_empty_property(self):
+        with pytest.raises(ValueError, match="value for 'property' must be given"):
+            self.channel_cls("some_id", "")
+
 
 class StateTest(make_base(), unittest.TestCase):
     channel_cls = State
@@ -97,3 +100,9 @@ class StateTest(make_base(), unittest.TestCase):
 class OutputTest(make_base(), unittest.TestCase):
     channel_cls = Output
     link_name = "target"
+
+    def test_allow_empty_property(self):
+        obj = self.channel_cls("some_id", "")
+        self.assertEqual("component", obj.link)
+        self.assertEqual("some_id", obj.id)
+        self.assertEqual("", obj.property)