Merge pull request #104 from bcdev/forman-dont_log_in_common_situations

Don't log in common situations

Author: forman

chartlets.js/CHANGES.md

@@ -1,3 +1,8 @@
+## Version 0.1.4 (in development)
+
+* In `chartlets.js` we no longer emit warnings and errors in common 
+  situations to avoid too much spam in the browser console.
+
 ## Version 0.1.3 (from 2025/01/28)
 
 * **Chore:** Version bump to align CI process with GitHub release flow. 

chartlets.js/package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "chartlets",
-  "version": "0.1.3",
+  "version": "0.1.4-dev.0",
   "description": "An experimental library for integrating interactive charts into existing JavaScript applications.",
   "type": "module",
   "files": [

chartlets.js/packages/lib/package.json

@@ -44,12 +44,18 @@ export function getInputValue(
   } else if (isHostChannel(input) && hostStore) {
     inputValue = getInputValueFromHostStore(hostStore, property);
   } else {
-    console.warn(`input with unknown data source:`, input);
+    // We no longer log, as the situation is quite common if a
+    // component has not yet been rendered.
+    // Enable logging for debugging only:
+    // console.warn(`input with unknown data source:`, input);
   }
   if (inputValue === undefined || inputValue === noValue) {
     // We use null, because undefined is not JSON-serializable.
     inputValue = null;
-    console.warn(`value is undefined for input`, input);
+    // We no longer log, as the situation is quite common if a
+    // component has not yet been rendered.
+    // Enable logging for debugging only:
+    // console.warn(`value is undefined for input`, input);
   }
   return inputValue;
 }

chartlets.js/packages/lib/src/actions/helpers/getInputValues.ts

@@ -12,9 +12,12 @@ export function Component(props: ComponentProps) {
   if (typeof ActualComponent === "function") {
     return <ActualComponent {...props} />;
   } else {
-    console.error(
-      `chartlets: invalid component type encountered: ${componentType}`,
-    );
+    // We no longer log, as the situation is quite common
+    // and users can not do anything against it.
+    // Enable error logging for debugging only:
+    // console.error(
+    //  `chartlets: invalid component type encountered: ${componentType}`,
+    // );
     return null;
   }
 }