Add test

Author: forman

chartlets.js/packages/lib/src/actions/handleHostStoreChange.ts

@@ -13,7 +13,7 @@ import { invokeCallbacks } from "@/actions/helpers/invokeCallbacks";
 import type { ContributionState } from "@/types/state/contribution";
 import type { HostStore } from "@/types/state/host";
 import { store } from "@/store";
-import { shallowEqualArrays } from "@/utils/compare";
+import { shallowEqualArrays } from "@/utils/shallowEqualArrays";
 import type { ContribPoint } from "@/types/model/extension";
 
 /**
@@ -109,8 +109,9 @@ const getCallbackRequest = (
 /**
  * Get the static list of host state property references
  * for given contribution points.
+ * Note: the export exists only for testing.
  */
-const getPropertyRefsForContribPoints = memoize(
+export const getPropertyRefsForContribPoints = memoize(
   _getPropertyRefsForContribPoints,
 );
 

chartlets.js/packages/lib/src/actions/handleHostStoreChanges.test.tsx

@@ -2,6 +2,7 @@ import { beforeEach, describe, expect, it } from "vitest";
 import { store } from "@/store";
 import {
   getCallbackRequests,
+  getPropertyRefsForContribPoints,
   handleHostStoreChange,
   type PropertyRef,
 } from "./handleHostStoreChange";
@@ -46,6 +47,76 @@ describe("handleHostStoreChange", () => {
     expect(store.getState().themeMode).toEqual("light");
   });
 
+  it("should memoize computation of property refs", () => {
+    const contributionsRecord: Record<string, ContributionState[]> = {
+      panels: [
+        {
+          name: "p0",
+          container: { title: "Panel A" },
+          extension: "e0",
+          componentResult: {},
+          initialState: {},
+          callbacks: [
+            {
+              function: {
+                name: "callback",
+                parameters: [],
+                return: {},
+              },
+              inputs: [{ id: "@app", property: "variableName" }],
+              outputs: [{ id: "select", property: "value" }],
+            },
+            {
+              function: {
+                name: "callback2",
+                parameters: [],
+                return: {},
+              },
+              inputs: [
+                { id: "@app", property: "datasetId" },
+                { id: "@app", property: "variableName" },
+              ],
+              outputs: [{ id: "plot", property: "value" }],
+            },
+          ],
+        },
+      ],
+    };
+    const propertyRefs1 = getPropertyRefsForContribPoints(contributionsRecord);
+    const propertyRefs2 = getPropertyRefsForContribPoints(contributionsRecord);
+    const propertyRefs3 = getPropertyRefsForContribPoints({
+      ...contributionsRecord,
+    });
+    expect(propertyRefs1).toBe(propertyRefs2);
+    expect(propertyRefs2).not.toBe(propertyRefs3);
+    expect(propertyRefs1).toEqual([
+      {
+        callbackIndex: 0,
+        contribIndex: 0,
+        contribPoint: "panels",
+        inputIndex: 0,
+        property: "variableName",
+      },
+      {
+        callbackIndex: 1,
+        contribIndex: 0,
+        contribPoint: "panels",
+        inputIndex: 0,
+        property: "datasetId",
+      },
+      {
+        callbackIndex: 1,
+        contribIndex: 0,
+        contribPoint: "panels",
+        inputIndex: 1,
+        property: "variableName",
+      },
+    ]);
+    expect(propertyRefs1).toEqual(propertyRefs2);
+    expect(propertyRefs1).toEqual(propertyRefs3);
+    expect(propertyRefs2).toEqual(propertyRefs3);
+  });
+
   it("should generate callback requests", () => {
     const extensions = [{ name: "e0", version: "0", contributes: ["panels"] }];
     store.setState({