readability improvements

Author: forman

dashi/src/demo/actions/hidePanel.ts

@@ -2,7 +2,12 @@ import { updateContributionContainer } from "@/lib";
 import type { PanelState } from "@/demo/types";
 
 export function hidePanel(panelIndex: number) {
-  updateContributionContainer<PanelState>("panels", panelIndex, {
-    visible: false,
-  });
+  updateContributionContainer<PanelState>(
+    "panels",
+    panelIndex,
+    {
+      visible: false,
+    },
+    false,
+  );
 }

dashi/src/lib/actions/handleComponentChange.ts

@@ -12,6 +12,7 @@ export function handleComponentChange(
   contribIndex: number,
   changeEvent: ComponentChangeEvent,
 ) {
+  // Apply actual component state change immediately
   applyStateChangeRequests([
     {
       contribPoint,

dashi/src/lib/actions/updateContributionContainer.ts

@@ -17,12 +17,12 @@ export function updateContributionContainer<S extends object = object>(
   if (contributionState.container === container) {
     return; // nothing to do
   }
-  const componentStatus = contributionState.componentResult.status;
-  if (!requireComponent || componentStatus) {
+  const isLayoutFetched = Boolean(contributionState.componentResult.status);
+  if (!requireComponent || isLayoutFetched) {
     _updateContributionState(contribPoint, contribIndex, {
       container,
     });
-  } else if (!componentStatus) {
+  } else if (!isLayoutFetched) {
     // No status yet, so we must load the component
     _updateContributionState(contribPoint, contribIndex, {
       container,

dashi/src/lib/api/types.ts

@@ -4,7 +4,7 @@ export interface ApiOptions {
 }
 
 export interface ApiResult<T> {
-  status?: "pending" | "ok" | "failed";
+  status?: "pending" | "ok" | "failed" | undefined;
   data?: T;
   error?: ApiError;
 }