Skip to content

Commit 36fe180

Browse files
committed
rename DockerHelper to DockerComposeHelper in MlopsManager and ruff
1 parent e08d76a commit 36fe180

File tree

3 files changed

+9
-16
lines changed

3 files changed

+9
-16
lines changed

src/gaiaflow/managers/minikube_manager.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -392,9 +392,7 @@ def create_kube_config_inline(self):
392392
self.kube_helper.create_inline()
393393

394394
def build_docker_image(self):
395-
dockerfile_path = (
396-
self.gaiaflow_path / "_docker" / "user-package" / "Dockerfile"
397-
)
395+
dockerfile_path = self.gaiaflow_path / "_docker" / "user-package" / "Dockerfile"
398396
self.docker_helper.build_image(dockerfile_path)
399397

400398
def create_secrets(self, secret_name: str, secret_data: dict[str, Any]):

src/gaiaflow/managers/mlops_manager.py

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ class DockerResources:
7272
}
7373

7474

75-
class DockerHelper:
75+
class DockerComposeHelper:
7676
def __init__(self, gaiaflow_path: Path, is_prod_local: bool):
7777
self.gaiaflow_path = gaiaflow_path
7878
self.is_prod_local = is_prod_local
@@ -224,7 +224,7 @@ def __init__(
224224
self.user_env_name = user_env_name
225225
self.env_tool = env_tool
226226

227-
self.docker = DockerHelper(gaiaflow_path, prod_local)
227+
self.docker = DockerComposeHelper(gaiaflow_path, prod_local)
228228
self.jupyter = JupyterHelper(
229229
jupyter_port, env_tool, user_env_name, gaiaflow_path
230230
)
@@ -405,9 +405,7 @@ def _create_gaiaflow_context(self):
405405
package_dir = Path(__file__).parent.parent.resolve()
406406
docker_dir = package_dir.parent / "_docker"
407407

408-
shutil.copytree(
409-
docker_dir, self.gaiaflow_path / "_docker", dirs_exist_ok=True
410-
)
408+
shutil.copytree(docker_dir, self.gaiaflow_path / "_docker", dirs_exist_ok=True)
411409
log_info(f"Gaiaflow context created at {self.gaiaflow_path}")
412410

413411
def _collect_volumes(self, compose_data: dict) -> list[str]:
@@ -471,10 +469,7 @@ def _update_files(self):
471469
yaml.preserve_quotes = True
472470

473471
compose_path = (
474-
self.gaiaflow_path
475-
/ "_docker"
476-
/ "docker-compose"
477-
/ "docker-compose.yml"
472+
self.gaiaflow_path / "_docker" / "docker-compose" / "docker-compose.yml"
478473
)
479474

480475
with open(compose_path) as f:

tests/managers/test_mlops_manager.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
from gaiaflow.managers.mlops_manager import (
1212
MlopsManager,
1313
JupyterHelper,
14-
DockerHelper,
14+
DockerComposeHelper,
1515
DockerResources,
1616
)
1717

@@ -316,22 +316,22 @@ def test_start_jupyter_env_not_exists(self, mock_popen, mock_env):
316316
mock_popen.assert_not_called()
317317

318318
def test_docker_helper_builds_command(self):
319-
helper = DockerHelper(self.manager.gaiaflow_path, is_prod_local=False)
319+
helper = DockerComposeHelper(self.manager.gaiaflow_path, is_prod_local=False)
320320
cmd = helper._base_cmd()
321321
self.assertIn("docker", cmd)
322322
self.assertIn("compose", cmd)
323323
self.assertEqual(cmd.count("-f"), 1)
324324

325325
def test_docker_helper_builds_command_prod_local(self):
326-
helper = DockerHelper(self.manager.gaiaflow_path, is_prod_local=True)
326+
helper = DockerComposeHelper(self.manager.gaiaflow_path, is_prod_local=True)
327327
cmd = helper._base_cmd()
328328
self.assertIn("docker", cmd)
329329
self.assertIn("compose", cmd)
330330
self.assertEqual(cmd.count("-f"), 2)
331331

332332

333333
def test_docker_services_for_known_and_unknown(self):
334-
helper = DockerHelper(Path("/tmp"), False)
334+
helper = DockerComposeHelper(Path("/tmp"), False)
335335
self.assertIn("mlflow", helper.docker_services_for("mlflow"))
336336
self.assertEqual(helper.docker_services_for("unknown"), [])
337337

0 commit comments

Comments
 (0)