removed useless input products for S2IdepixCloudPostProcessOp and minor refactoring

Author: marpet

idepix-s2msi/src/main/java/org/esa/snap/idepix/s2msi/S2IdepixOp.java

@@ -141,18 +141,14 @@ private Product createS2ClassificationProduct(Map<String, Product> inputProducts
 
     private Product computePostProcessProduct(Product l1cProduct, Product classificationProduct) {
 
-        // todo: Shouldn't this be actually within the if clause?
         HashMap<String, Product> input = new HashMap<>();
-        input.put("l1c", l1cProduct);
-        input.put("s2Cloud", classificationProduct);
         input.put("classifiedProduct", classificationProduct);
         Map<String, Object> paramsBuffer = new HashMap<>();
         paramsBuffer.put("cloudBufferWidth", cloudBufferWidth);
         paramsBuffer.put("computeCloudBufferForCloudAmbiguous", computeCloudBufferForCloudAmbiguous);
         Product cloudBufferProduct = GPF.createProduct(OperatorSpi.getOperatorAlias(S2IdepixCloudPostProcessOp.class),
                                                        paramsBuffer, input);
 
-        Product postProduct = cloudBufferProduct;
 
         if (computeCloudShadow || computeMountainShadow || computeCloudBuffer) {
             HashMap<String, Product> inputShadow = new HashMap<>();
@@ -167,11 +163,12 @@ private Product computePostProcessProduct(Product l1cProduct, Product classifica
             params.put("computeCloudBufferForCloudAmbiguous", computeCloudBufferForCloudAmbiguous);
             params.put("mode", "LandWater");
             params.put("demName", demName);
-            postProduct = GPF.createProduct(OperatorSpi.getOperatorAlias(S2IdepixPostProcessOp.class),
+            return GPF.createProduct(OperatorSpi.getOperatorAlias(S2IdepixPostProcessOp.class),
                                                       params, inputShadow);
+        } else {
+            return cloudBufferProduct;
         }
 
-        return postProduct;
     }