links can be at any level

Author: forman

tests/plugins/xcube/processors/test_mldataset.py

@@ -16,10 +16,6 @@
 from xrlint.plugins.xcube.util import LevelInfo, LevelsMeta
 from xrlint.result import Message
 
-# TODO: This tests requires zarr >=2, <3, because the test used fsspec's
-#   memory filesystem, which is not async but zarr wants all filesystems
-#   to be async now.
-
 
 class MultiLevelDatasetProcessorTest(TestCase):
     levels_name = "xrlint-test"

tests/plugins/xcube/test_util.py

@@ -0,0 +1,36 @@
+#  Copyright © 2025 Brockmann Consult GmbH.
+#  This software is distributed under the terms and conditions of the
+#  MIT license (https://mit-license.org/).
+
+from unittest import TestCase
+
+from xrlint.plugins.xcube.util import is_absolute_path
+from xrlint.plugins.xcube.util import resolve_path
+
+
+class UtilTest(TestCase):
+    def test_is_absolute_path(self):
+        self.assertTrue(is_absolute_path("/home/forman"))
+        self.assertTrue(is_absolute_path("//bcserver2/fs1"))
+        self.assertTrue(is_absolute_path("file://home/forman"))
+        self.assertTrue(is_absolute_path("s3://xcube-data"))
+        self.assertTrue(is_absolute_path(r"C:\Users\Norman"))
+        self.assertTrue(is_absolute_path(r"C:/Users/Norman"))
+        self.assertTrue(is_absolute_path(r"C:/Users/Norman"))
+        self.assertTrue(is_absolute_path(r"\\bcserver2\fs1"))
+
+        self.assertFalse(is_absolute_path(r"data"))
+        self.assertFalse(is_absolute_path(r"./data"))
+        self.assertFalse(is_absolute_path(r"../data"))
+
+    def test_resolve_path(self):
+        self.assertEqual(
+            "/home/forman/data", resolve_path("data", root_path="/home/forman")
+        )
+        self.assertEqual(
+            "/home/forman/data", resolve_path("./data", root_path="/home/forman")
+        )
+        self.assertEqual(
+            "/home/data", resolve_path("../data", root_path="/home/forman")
+        )
+        self.assertEqual("s3://opensr/test.zarr", resolve_path("s3://opensr/test.zarr"))

xrlint/plugins/xcube/processors/mldataset.py

@@ -15,7 +15,7 @@
 from xrlint.plugins.xcube.util import (
     LevelsMeta,
     attach_dataset_level_infos,
-    norm_link_path,
+    resolve_path,
 )
 from xrlint.processor import ProcessorOp
 from xrlint.result import Message
@@ -46,11 +46,11 @@ def preprocess(
                 meta = LevelsMeta.from_value(json.load(stream))
 
         # check for optional ".zgroup"
-        if ".zgroup" in file_names:
-            with fs.open(f"{fs_path}/.zgroup") as stream:
-                group_props = json.load(stream)
+        # if ".zgroup" in file_names:
+        #     with fs.open(f"{fs_path}/.zgroup") as stream:
+        #         group_props = json.load(stream)
 
-        level_paths, num_levels = parse_levels(fs, fs_path, file_names)
+        level_paths, num_levels = parse_levels(fs, file_path, file_names)
 
         engine = opener_options.pop("engine", "zarr")
 
@@ -93,7 +93,7 @@ def parse_levels(
         if m is not None:
             level = int(m.group(1))
             link_path = fs.read_text(f"{dataset_path}/{file_name}")
-            level_paths[level] = norm_link_path(dataset_path, link_path)
+            level_paths[level] = resolve_path(link_path, root_path=dataset_path)
         # check for regular "<level>.zarr"
         m = level_pattern.match(file_name)
         if m is not None:

xrlint/plugins/xcube/util.py

@@ -95,11 +95,10 @@ def get_spatial_size(
     return None
 
 
-def norm_link_path(dataset_path: str, link_path: str) -> str:
-    if is_absolute_path(link_path):
-        abs_level_path = link_path
-    else:
-        abs_level_path = f"{dataset_path}/{link_path}"
+def resolve_path(path: str, root_path: str | None = None) -> str:
+    abs_level_path = path
+    if root_path is not None and not is_absolute_path(path):
+        abs_level_path = f"{root_path}/{path}"
     parts = abs_level_path.rstrip("/").replace("\\", "/").split("/")
     return "/".join(
         p