Skip to content

Commit 1426d5f

Browse files
committed
Fixes
1 parent 8c16501 commit 1426d5f

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

CONTRIBUTING.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ sort imports statements according to the default settings of
5252
Use `typing.TYPE_CHECKING` to resolve forward references
5353
and effectively avoid circular dependencies.
5454

55-
## Contributing Rules
55+
## Contributing a XRLint Rule
5656

5757
### Rule Naming
5858

@@ -81,6 +81,7 @@ The rule naming conventions for XRLint are based ESLint:
8181
i.e., `<plugin>/rules/<rule>`. The module name should be the rule's name
8282
with dashes replaced by underscores.
8383

84-
* Write a comprehensive test for your rule logic using
85-
`xrlint.testing.RuleTester`. It should be defined in a dedicated
86-
test module, i.e., `tests/rules/test_<rule>`.
84+
* Write a comprehensive test for your rule logic which should be defined
85+
in a dedicated module under `tests`, i.e., `tests/rules/test_<rule>`.
86+
Consider using `xrlint.testing.RuleTester` which can save a lot of
87+
time and is used for almost all in-built rules.

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,9 @@ The following plugins provide XRLint's [inbuilt rules](https://bcdev.github.io/x
3030
[tidy data](https://tutorial.xarray.dev/intermediate/data_cleaning/05.1_intro.html)
3131
and the
3232
[CF-Conventions](https://cfconventions.org/cf-conventions/cf-conventions.html).
33-
- `xrlint.plugins.core`: implementing the rules for
33+
- `xrlint.plugins.xcube`: implementing the rules for
3434
[xcube datasets](https://xcube.readthedocs.io/en/latest/cubespec.html).
3535
Note, this plugin is fully optional. You must manually configure
36-
it to apply its rules. It may be moved into a separate GitHub repo
37-
once XRLint is mature enough.
36+
it to apply its rules. It may be moved into a separate GitHub repo later.
37+
3838

docs/index.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,5 @@ The following plugins provide XRLint's [inbuilt rules](rule-ref.md):
2929
- `xcube`: implementing the rules for
3030
[xcube datasets](https://xcube.readthedocs.io/en/latest/cubespec.html).
3131
Note, this plugin is fully optional. You must manually configure
32-
it to apply its rules. It may be moved into a separate GitHub repo
33-
once XRLint is mature enough.
32+
it to apply its rules. It may be moved into a separate GitHub repo later.
3433

0 commit comments

Comments
 (0)