More consistent messages.

Author: forman

xrlint/plugins/core/rules/coords_for_dims.py

@@ -31,7 +31,7 @@ def dataset(self, ctx: RuleContext, node: DatasetNode):
             n = len(no_coord_dims)
             ctx.report(
                 f"{format_item(n, 'Data variable dimension')} without"
-                f" coordinates: {', '.join(no_coord_dims)}",
+                f" coordinates: {', '.join(no_coord_dims)}.",
                 suggestions=[
                     f"Add corresponding {format_item(n, 'coordinate variable')}"
                     f" to dataset:"

xrlint/plugins/core/rules/flags.py

@@ -70,7 +70,7 @@ def _validate_flag_values(
 ) -> int | None:
     if not has_meanings:
         ctx.report(
-            f"Missing attribute {FLAG_MEANINGS!r} to explain attribute {FLAG_VALUES!r}"
+            f"Missing attribute {FLAG_MEANINGS!r} to explain attribute {FLAG_VALUES!r}."
         )
     type_ok, flag_count = _check_values(flag_values)
     if not type_ok or flag_count is None:

xrlint/plugins/core/rules/no_empty_chunks.py

@@ -30,4 +30,4 @@ def data_array(self, ctx: RuleContext, node: DataArrayNode):
             and "chunks" in node.data_array.encoding
             and "_FillValue" in node.data_array.encoding
         ):
-            ctx.report("Consider writing the dataset using 'write_empty_chunks=True`.")
+            ctx.report("Consider writing the dataset using 'write_empty_chunks=True'.")

xrlint/plugins/core/rules/time_coordinate.py

@@ -57,7 +57,7 @@ def data_array(self, ctx: RuleContext, node: DataArrayNode):
             has_tz = last_part.lower() == "utc" or last_part[0] in ("+", "-")
             if not has_tz:
                 ctx.report(
-                    f"Missing timezone in 'units' attribute: {units}",
+                    f"Missing timezone in 'units' attribute: {units!r}.",
                     suggestions=[
                         use_units_format_msg,
                         f"Append timezone specification, e.g., use"
@@ -68,6 +68,6 @@ def data_array(self, ctx: RuleContext, node: DataArrayNode):
             return
 
         ctx.report(
-            f"Invalid 'units' attribute: {units}",
+            f"Invalid 'units' attribute: {units!r}.",
             suggestions=[use_units_format_msg],
         )

xrlint/plugins/xcube/rules/data_var_colors.py

@@ -23,17 +23,17 @@ def data_array(self, ctx: RuleContext, node: DataArrayNode):
         attrs = array.attrs
         color_bar_name = attrs.get("color_bar_name")
         if not color_bar_name:
-            ctx.report("Missing attribute 'color_bar_name'")
+            ctx.report("Missing attribute 'color_bar_name'.")
         else:
             color_value_min = attrs.get("color_value_min")
             color_value_max = attrs.get("color_value_max")
             if color_value_min is None or color_value_max is None:
                 ctx.report(
-                    "Missing both or one of 'color_value_min' and 'color_value_max'"
+                    "Missing both or one of 'color_value_min' and 'color_value_max'."
                 )
 
             color_norm = attrs.get("color_norm")
             if color_norm and color_norm not in ("lin", "log"):
                 ctx.report(
-                    "Invalid value of attribute 'color_norm', should be 'lin' or 'log'"
+                    "Invalid value of attribute 'color_norm', should be 'lin' or 'log'."
                 )

xrlint/plugins/xcube/rules/grid_mapping_naming.py

@@ -21,5 +21,5 @@ def dataset(self, ctx: RuleContext, node: DatasetNode):
                 ctx.report(
                     f"Grid mapping variables should be named"
                     f" {GM_NAMES_TEXT},"
-                    f" but name is {var_name!r}"
+                    f" but name is {var_name!r}."
                 )

xrlint/plugins/xcube/rules/increasing_time.py

@@ -32,5 +32,5 @@ def check_indexes(ctx, cond: np.ndarray, issue_name: str):
         index_text = format_count(indexes.size, singular="index", plural="indexes")
         ctx.report(
             f"{issue_name} 'time' coordinate label at {index_text}"
-            f" {format_seq(indexes)}"
+            f" {format_seq(indexes)}."
         )

xrlint/plugins/xcube/rules/ml_dataset_meta.py

@@ -40,17 +40,17 @@ def dataset(self, ctx: RuleContext, node: DatasetNode):
             return
 
         if not meta.version.startswith("1."):
-            ctx.report(f"Unsupported {ML_META_FILENAME!r} meta-info version")
+            ctx.report(f"Unsupported {ML_META_FILENAME!r} meta-info version.")
 
         if meta.num_levels <= 0:
             ctx.report(
                 f"Invalid 'num_levels' in {ML_META_FILENAME!r} meta-info:"
-                f" {meta.num_levels}"
+                f" {meta.num_levels}."
             )
         elif meta.num_levels != level_info.num_levels:
             ctx.report(
                 f"Expected {format_item(meta.num_levels, 'level')},"
-                f" but found {level_info.num_levels}"
+                f" but found {level_info.num_levels}."
             )
 
         if meta.use_saved_levels is None:

xrlint/plugins/xcube/rules/ml_dataset_time.py

@@ -35,5 +35,5 @@ def dataset(self, ctx: RuleContext, node: DatasetNode):
                 if not all(c == 1 for c in time_chunks):
                     ctx.report(
                         f"Variable {var_name!r} uses chunking for {TIME_NAME!r}"
-                        f" that differs from from one: {format_seq(time_chunks)}"
+                        f" that differs from from one: {format_seq(time_chunks)}."
                     )

xrlint/plugins/xcube/rules/ml_dataset_xy.py

@@ -45,13 +45,13 @@ def dataset(self, ctx: RuleContext, node: DatasetNode):
         if level_width != expected_level_width:
             ctx.report(
                 f"Expected size of dimension {x_name!r} in level {level}"
-                f" to be {expected_level_width}, but was {level_width}"
+                f" to be {expected_level_width}, but was {level_width}."
             )
 
         if level_height != expected_level_height:
             ctx.report(
                 f"Expected size of dimension {y_name!r} in level {level}"
-                f" to be {expected_level_height}, but was {level_height}"
+                f" to be {expected_level_height}, but was {level_height}."
             )
 
         # Here: check spatial coordinates...