["tottime"] is a reasonable default for keys

Author: forman

docs/config.md

@@ -191,27 +191,35 @@ Defaults to `false`.
 
 Profiling configuration. Allows for runtime profiling of the processing.
 Must be one of the following:
+
 * Type _boolean_.
   If set, profiling is enabled and output is logged using level INFO. Otherwise, profiling is disabled.
+
 * Type _string_.
   Profile path. Enables profiling and writes a profiling report to given path.
+
 * Type _object_.
 
   * `enabled`:
     Type _boolean_.
     Enable or disable profiling.
+  
   * `path`:
     Type _string_.
     Local file path for profiling output.
+  
   * `log_level`:
     Log level. Use 'NOTSET' to disable logging.
     Defaults to `"INFO"`.
     Must be one of `"CRITICAL", "ERROR", "WARNING", "INFO", "DEBUG", "NOTSET"`.
+  
   * `keys`:
     Type _array_.
     Sort output according to the supplied column names. Refer to [Stats.sort_stats(*keys)](https://docs.python.org/3/library/profile.html#pstats.Stats.sort_stats).
+    Defaults to `["tottime"]`.
 
     Must be one of `"calls", "cumulative", "cumtime", "file", "filename", "module", "ncalls", "pcalls", "line", "name", "nfl", "stdname", "time", "tottime"`.
+  
   * `restrictions`:
     Type _array_.
     Used to limit the list down to the significant entries in the profiling report. Refer to [Stats.print_stats(*restrictions)](https://docs.python.org/3/library/profile.html#pstats.Stats.print_stats).

tests/test_profiler.py

@@ -12,37 +12,38 @@
 class ProfilerTest(unittest.TestCase):
     def test_disabled(self):
         profiler = Profiler(None)
-        self.assertEqual(False, profiler.enabled)
+        self.assert_profiler_config(profiler, False)
         with profiler:
             pass
 
         profiler = Profiler(False)
-        self.assertEqual(False, profiler.enabled)
+        self.assert_profiler_config(profiler, False)
         with profiler:
             pass
 
         profiler = Profiler({"enabled": False})
-        self.assertEqual(False, profiler.enabled)
+        self.assert_profiler_config(profiler, False)
         with profiler:
             pass
 
         profiler = Profiler({"log_level": "NOTSET"})
-        self.assertEqual(False, profiler.enabled)
+        self.assert_profiler_config(profiler, False, "NOTSET")
+        with profiler:
+            pass
+
+        profiler = Profiler({"enabled": True, "log_level": "NOTSET"})
+        self.assert_profiler_config(profiler, False, "NOTSET")
         with profiler:
             pass
 
     def test_enabled(self):
         profiler = Profiler(True)
-        self.assertEqual(True, profiler.enabled)
-        self.assertEqual("INFO", profiler.log_level)
-        self.assertEqual(None, profiler.path)
+        self.assert_profiler_config(profiler, True, "INFO")
         with profiler:
             pass
 
         profiler = Profiler("prof.out")
-        self.assertEqual(True, profiler.enabled)
-        self.assertEqual("INFO", profiler.log_level)
-        self.assertEqual("prof.out", profiler.path)
+        self.assert_profiler_config(profiler, True, "INFO", "prof.out")
         try:
             with profiler:
                 pass
@@ -52,13 +53,30 @@ def test_enabled(self):
                 os.remove("prof.out")
 
         profiler = Profiler({"path": "prof.out", "log_level": "DEBUG"})
-        self.assertEqual(True, profiler.enabled)
-        self.assertEqual("DEBUG", profiler.log_level)
-        self.assertEqual("prof.out", profiler.path)
+        self.assert_profiler_config(profiler, True, "DEBUG", "prof.out")
         try:
             with profiler:
                 pass
             self.assertTrue(os.path.exists("prof.out"))
         finally:
             if os.path.exists("prof.out"):
                 os.remove("prof.out")
+
+    def assert_profiler_config(
+        self,
+        profiler: Profiler,
+        expected_enabled,
+        expected_log_level="INFO",
+        expected_path=None,
+        expected_keys=None,
+        expected_restrictions=None,
+    ):
+        if expected_keys is None:
+            expected_keys = ["tottime"]
+        if expected_restrictions is None:
+            expected_restrictions = []
+        self.assertEqual(expected_enabled, profiler.enabled)
+        self.assertEqual(expected_log_level, profiler.log_level)
+        self.assertEqual(expected_path, profiler.path)
+        self.assertEqual(expected_keys, profiler.keys)
+        self.assertEqual(expected_restrictions, profiler.restrictions)

zappend/config/schema.py

@@ -234,6 +234,7 @@
                         "(https://docs.python.org/3/library/profile.html"
                         "#pstats.Stats.sort_stats)."
                     ),
+                    "default": ["tottime"],
                     "type": "array",
                     "items": {
                         "enum": [

zappend/profiler.py

@@ -26,7 +26,7 @@ def __init__(self, profiling_config: dict[str, Any] | str | bool | None):
         # Defaults
         path = None
         log_level = "INFO"
-        keys = []
+        keys = ["tottime"]
         restrictions = []
 
         if isinstance(profiling_config, str):