Introduced new setting "disable_rollback"

Author: forman

CONFIG.md

@@ -149,6 +149,12 @@ Specifies the names of variables to be included in the target dataset. Defaults
 Type _array_.
 Specifies the names of individual variables to be excluded  from all contributing datasets.
 
+### `disable_rollback`
+
+Type _boolean_.
+Disable rolling back dataset changes on failure. Effectively disables transactional dataset modifications, so use this setting with care.
+Defaults to `false`.
+
 ### `dry_run`
 
 Type _boolean_.

tests/test_config.py

@@ -209,6 +209,7 @@ def test_schema(self):
         self.assertEqual(
             {
                 'append_dim',
+                'disable_rollback',
                 'dry_run',
                 'excluded_variables',
                 'fixed_dims',

tests/test_context.py

@@ -61,6 +61,13 @@ def test_temp_dir(self):
         self.assertIsInstance(ctx.temp_dir, FileObj)
         self.assertTrue(ctx.temp_dir.exists())
 
+    def test_disable_rollback(self):
+        ctx = Context({"target_uri": "memory://target.zarr"})
+        self.assertFalse(ctx.disable_rollback)
+        ctx = Context({"target_uri": "memory://target.zarr",
+                       "disable_rollback": True})
+        self.assertTrue(ctx.disable_rollback)
+
     def test_dry_run(self):
         ctx = Context({"target_uri": "memory://target.zarr"})
         self.assertEqual(False, ctx.dry_run)

zappend/config.py

@@ -408,6 +408,14 @@
             "items": {"type": "string", "minLength": 1}
         },
 
+        disable_rollback={
+            "description": "Disable rolling back dataset changes on failure."
+                           " Effectively disables transactional dataset"
+                           " modifications, so use this setting with care.",
+            "type": "boolean",
+            "default": False
+        },
+
         dry_run={
             "description": "If 'true', log only what would have been done,"
                            " but don't apply any changes.",

zappend/context.py

@@ -13,7 +13,6 @@
 from .config import DEFAULT_ZARR_VERSION
 from .metadata import DatasetMetadata
 from .fsutil.fileobj import FileObj
-from .log import logger
 
 
 class Context:
@@ -99,6 +98,10 @@ def slice_polling(self) -> tuple[float, float] | tuple[None, None]:
     def temp_dir(self) -> FileObj:
         return self._temp_dir
 
+    @property
+    def disable_rollback(self) -> bool:
+        return self._config.get("disable_rollback", False)
+
     @property
     def dry_run(self) -> bool:
         return self._config.get("dry_run", False)

zappend/processor.py

@@ -67,15 +67,18 @@ def process_slice(self, slice_obj: str | xr.Dataset):
                     ctx.append_dim_name
                 )
 
-            with Transaction(ctx.target_dir, ctx.temp_dir) as rollback_cb:
+            transaction = Transaction(ctx.target_dir,
+                                      ctx.temp_dir,
+                                      disable_rollback=ctx.disable_rollback)
+            with transaction as rollback_callback:
                 if ctx.target_metadata is slice_metadata:
                     create_target_from_slice(ctx,
                                              slice_dataset,
-                                             rollback_cb)
+                                             rollback_callback)
                 else:
                     update_target_from_slice(ctx,
                                              slice_dataset,
-                                             rollback_cb)
+                                             rollback_callback)
 
 
 def create_target_from_slice(ctx: Context,