Misc. updates from bc-java

Author: peterdettman

crypto/src/asn1/pkcs/PrivateKeyInfo.cs

@@ -151,6 +151,11 @@ private PrivateKeyInfo(Asn1Sequence seq)
             }
         }
 
+        public virtual DerInteger Version
+        {
+            get { return version; }
+        }
+
         public virtual Asn1Set Attributes
         {
             get { return attributes; }

crypto/src/crypto/encodings/Pkcs1Encoding.cs

@@ -224,7 +224,7 @@ private static int CheckPkcs1Encoding(byte[] encoded, int pLen)
              * Now the padding check, check for no 0 byte in the padding
              */
             int plen = encoded.Length - (
-                      pLen /* Lenght of the PMS */
+                      pLen /* Length of the PMS */
                     +  1 /* Final 0-byte before PMS */
             );
 

crypto/src/crypto/tls/TlsDHKeyExchange.cs

@@ -73,7 +73,7 @@ public override void ProcessServerCertificate(Certificate serverCertificate)
             if (mKeyExchange == KeyExchangeAlgorithm.DH_anon)
                 throw new TlsFatalAlert(AlertDescription.unexpected_message);
             if (serverCertificate.IsEmpty)
-                throw new TlsFatalAlert(AlertDescription.bad_certificate);
+                throw new TlsFatalAlert(AlertDescription.decode_error);
 
             X509CertificateStructure x509Cert = serverCertificate.GetCertificateAt(0);
 

crypto/src/crypto/tls/TlsECDHKeyExchange.cs

@@ -69,7 +69,7 @@ public override void ProcessServerCertificate(Certificate serverCertificate)
             if (mKeyExchange == KeyExchangeAlgorithm.ECDH_anon)
                 throw new TlsFatalAlert(AlertDescription.unexpected_message);
             if (serverCertificate.IsEmpty)
-                throw new TlsFatalAlert(AlertDescription.bad_certificate);
+                throw new TlsFatalAlert(AlertDescription.decode_error);
 
             X509CertificateStructure x509Cert = serverCertificate.GetCertificateAt(0);
 

crypto/src/crypto/tls/TlsPskKeyExchange.cs

@@ -126,7 +126,7 @@ public override void ProcessServerCertificate(Certificate serverCertificate)
             if (mKeyExchange != KeyExchangeAlgorithm.RSA_PSK)
                 throw new TlsFatalAlert(AlertDescription.unexpected_message);
             if (serverCertificate.IsEmpty)
-                throw new TlsFatalAlert(AlertDescription.bad_certificate);
+                throw new TlsFatalAlert(AlertDescription.decode_error);
 
             X509CertificateStructure x509Cert = serverCertificate.GetCertificateAt(0);
 

crypto/src/crypto/tls/TlsRsaKeyExchange.cs

@@ -47,7 +47,7 @@ public override void ProcessServerCredentials(TlsCredentials serverCredentials)
         public override void ProcessServerCertificate(Certificate serverCertificate)
         {
             if (serverCertificate.IsEmpty)
-                throw new TlsFatalAlert(AlertDescription.bad_certificate);
+                throw new TlsFatalAlert(AlertDescription.decode_error);
 
             X509CertificateStructure x509Cert = serverCertificate.GetCertificateAt(0);
 

crypto/src/crypto/tls/TlsSrpKeyExchange.cs

@@ -97,7 +97,7 @@ public override void ProcessServerCertificate(Certificate serverCertificate)
             if (mTlsSigner == null)
                 throw new TlsFatalAlert(AlertDescription.unexpected_message);
             if (serverCertificate.IsEmpty)
-                throw new TlsFatalAlert(AlertDescription.bad_certificate);
+                throw new TlsFatalAlert(AlertDescription.decode_error);
 
             X509CertificateStructure x509Cert = serverCertificate.GetCertificateAt(0);
 

crypto/src/util/Arrays.cs

@@ -782,5 +782,15 @@ public static bool IsNullOrContainsNull(object[] array)
             }
             return false;
         }
+
+        public static bool IsNullOrEmpty(byte[] array)
+        {
+            return null == array || array.Length < 1;
+        }
+
+        public static bool IsNullOrEmpty(object[] array)
+        {
+            return null == array || array.Length < 1;
+        }
     }
 }