Fixed loop count for BigInteger conversion

peterdettman · peterdettman · commit 5e4ffd78e073 · 2020-09-11T11:54:39.000+07:00
- remove length-specific variants of FromBigInteger
diff --git a/crypto/src/math/ec/custom/djb/Curve25519Field.cs b/crypto/src/math/ec/custom/djb/Curve25519Field.cs
@@ -47,7 +47,7 @@ public static void AddOne(uint[] x, uint[] z)
 
         public static uint[] FromBigInteger(BigInteger x)
         {
-            uint[] z = Nat256.FromBigInteger(x);
+            uint[] z = Nat.FromBigInteger(256, x);
             while (Nat256.Gte(z, P))
             {
                 Nat256.SubFrom(P, z);
diff --git a/crypto/src/math/ec/custom/gm/SM2P256V1Field.cs b/crypto/src/math/ec/custom/gm/SM2P256V1Field.cs
@@ -47,7 +47,7 @@ public static void AddOne(uint[] x, uint[] z)
 
         public static uint[] FromBigInteger(BigInteger x)
         {
-            uint[] z = Nat256.FromBigInteger(x);
+            uint[] z = Nat.FromBigInteger(256, x);
             if (z[7] >= P7 && Nat256.Gte(z, P))
             {
                 Nat256.SubFrom(P, z);
diff --git a/crypto/src/math/ec/custom/sec/SecP128R1Field.cs b/crypto/src/math/ec/custom/sec/SecP128R1Field.cs
@@ -47,7 +47,7 @@ public static void AddOne(uint[] x, uint[] z)
 
         public static uint[] FromBigInteger(BigInteger x)
         {
-            uint[] z = Nat128.FromBigInteger(x);
+            uint[] z = Nat.FromBigInteger(128, x);
             if (z[3] >= P3 && Nat128.Gte(z, P))
             {
                 Nat128.SubFrom(P, z);
diff --git a/crypto/src/math/ec/custom/sec/SecP160R1Field.cs b/crypto/src/math/ec/custom/sec/SecP160R1Field.cs
@@ -51,7 +51,7 @@ public static void AddOne(uint[] x, uint[] z)
 
         public static uint[] FromBigInteger(BigInteger x)
         {
-            uint[] z = Nat160.FromBigInteger(x);
+            uint[] z = Nat.FromBigInteger(160, x);
             if (z[4] == P4 && Nat160.Gte(z, P))
             {
                 Nat160.SubFrom(P, z);
diff --git a/crypto/src/math/ec/custom/sec/SecP160R2Field.cs b/crypto/src/math/ec/custom/sec/SecP160R2Field.cs
@@ -51,7 +51,7 @@ public static void AddOne(uint[] x, uint[] z)
 
         public static uint[] FromBigInteger(BigInteger x)
         {
-            uint[] z = Nat160.FromBigInteger(x);
+            uint[] z = Nat.FromBigInteger(160, x);
             if (z[4] == P4 && Nat160.Gte(z, P))
             {
                 Nat160.SubFrom(P, z);
diff --git a/crypto/src/math/ec/custom/sec/SecP192K1Field.cs b/crypto/src/math/ec/custom/sec/SecP192K1Field.cs
@@ -52,7 +52,7 @@ public static void AddOne(uint[] x, uint[] z)
 
         public static uint[] FromBigInteger(BigInteger x)
         {
-            uint[] z = Nat192.FromBigInteger(x);
+            uint[] z = Nat.FromBigInteger(192, x);
             if (z[5] == P5 && Nat192.Gte(z, P))
             {
                 Nat192.SubFrom(P, z);
diff --git a/crypto/src/math/ec/custom/sec/SecP192R1Field.cs b/crypto/src/math/ec/custom/sec/SecP192R1Field.cs
@@ -51,7 +51,7 @@ public static void AddOne(uint[] x, uint[] z)
 
         public static uint[] FromBigInteger(BigInteger x)
         {
-            uint[] z = Nat192.FromBigInteger(x);
+            uint[] z = Nat.FromBigInteger(192, x);
             if (z[5] == P5 && Nat192.Gte(z, P))
             {
                 Nat192.SubFrom(P, z);
diff --git a/crypto/src/math/ec/custom/sec/SecP224K1Field.cs b/crypto/src/math/ec/custom/sec/SecP224K1Field.cs
@@ -53,7 +53,7 @@ public static void AddOne(uint[] x, uint[] z)
 
         public static uint[] FromBigInteger(BigInteger x)
         {
-            uint[] z = Nat224.FromBigInteger(x);
+            uint[] z = Nat.FromBigInteger(224, x);
             if (z[6] == P6 && Nat224.Gte(z, P))
             {
                 Nat224.SubFrom(P, z);
diff --git a/crypto/src/math/ec/custom/sec/SecP224R1Field.cs b/crypto/src/math/ec/custom/sec/SecP224R1Field.cs
@@ -52,7 +52,7 @@ public static void AddOne(uint[] x, uint[] z)
 
         public static uint[] FromBigInteger(BigInteger x)
         {
-            uint[] z = Nat224.FromBigInteger(x);
+            uint[] z = Nat.FromBigInteger(224, x);
             if (z[6] == P6 && Nat224.Gte(z, P))
             {
                 Nat224.SubFrom(P, z);
diff --git a/crypto/src/math/ec/custom/sec/SecP256K1Field.cs b/crypto/src/math/ec/custom/sec/SecP256K1Field.cs
@@ -53,7 +53,7 @@ public static void AddOne(uint[] x, uint[] z)
 
         public static uint[] FromBigInteger(BigInteger x)
         {
-            uint[] z = Nat256.FromBigInteger(x);
+            uint[] z = Nat.FromBigInteger(256, x);
             if (z[7] == P7 && Nat256.Gte(z, P))
             {
                 Nat256.SubFrom(P, z);
diff --git a/crypto/src/math/ec/custom/sec/SecP256R1Field.cs b/crypto/src/math/ec/custom/sec/SecP256R1Field.cs
@@ -47,7 +47,7 @@ public static void AddOne(uint[] x, uint[] z)
 
         public static uint[] FromBigInteger(BigInteger x)
         {
-            uint[] z = Nat256.FromBigInteger(x);
+            uint[] z = Nat.FromBigInteger(256, x);
             if (z[7] == P7 && Nat256.Gte(z, P))
             {
                 Nat256.SubFrom(P, z);
diff --git a/crypto/src/math/raw/Nat.cs b/crypto/src/math/raw/Nat.cs
@@ -515,32 +515,42 @@ public static uint EqualToZero(int len, uint[] x, int xOff)
 
         public static uint[] FromBigInteger(int bits, BigInteger x)
         {
+            if (bits < 1)
+                throw new ArgumentException();
             if (x.SignValue < 0 || x.BitLength > bits)
                 throw new ArgumentException();
 
             int len = (bits + 31) >> 5;
+            Debug.Assert(len > 0);
             uint[] z = Create(len);
-            int i = 0;
-            while (x.SignValue != 0)
+
+            // NOTE: Use a fixed number of loop iterations
+            z[0] = (uint)x.IntValue;
+            for (int i = 1; i < len; ++i)
             {
-                z[i++] = (uint)x.IntValue;
                 x = x.ShiftRight(32);
+                z[i] = (uint)x.IntValue;
             }
             return z;
         }
 
         public static ulong[] FromBigInteger64(int bits, BigInteger x)
         {
+            if (bits < 1)
+                throw new ArgumentException();
             if (x.SignValue < 0 || x.BitLength > bits)
                 throw new ArgumentException();
 
             int len = (bits + 63) >> 6;
+            Debug.Assert(len > 0);
             ulong[] z = Create64(len);
-            int i = 0;
-            while (x.SignValue != 0)
+
+            // NOTE: Use a fixed number of loop iterations
+            z[0] = (ulong)x.LongValue;
+            for (int i = 1; i < len; ++i)
             {
-                z[i++] = (ulong)x.LongValue;
                 x = x.ShiftRight(64);
+                z[i] = (ulong)x.LongValue;
             }
             return z;
         }
diff --git a/crypto/src/math/raw/Nat128.cs b/crypto/src/math/raw/Nat128.cs
@@ -185,36 +185,6 @@ public static bool Eq64(ulong[] x, ulong[] y)
             return true;
         }
 
-        public static uint[] FromBigInteger(BigInteger x)
-        {
-            if (x.SignValue < 0 || x.BitLength > 128)
-                throw new ArgumentException();
-
-            uint[] z = Create();
-            int i = 0;
-            while (x.SignValue != 0)
-            {
-                z[i++] = (uint)x.IntValue;
-                x = x.ShiftRight(32);
-            }
-            return z;
-        }
-
-        public static ulong[] FromBigInteger64(BigInteger x)
-        {
-            if (x.SignValue < 0 || x.BitLength > 128)
-                throw new ArgumentException();
-
-            ulong[] z = Create64();
-            int i = 0;
-            while (x.SignValue != 0)
-            {
-                z[i++] = (ulong)x.LongValue;
-                x = x.ShiftRight(64);
-            }
-            return z;
-        }
-
         public static uint GetBit(uint[] x, int bit)
         {
             if (bit == 0)
diff --git a/crypto/src/math/raw/Nat160.cs b/crypto/src/math/raw/Nat160.cs
@@ -172,21 +172,6 @@ public static bool Eq(uint[] x, uint[] y)
             return true;
         }
 
-        public static uint[] FromBigInteger(BigInteger x)
-        {
-            if (x.SignValue < 0 || x.BitLength > 160)
-                throw new ArgumentException();
-
-            uint[] z = Create();
-            int i = 0;
-            while (x.SignValue != 0)
-            {
-                z[i++] = (uint)x.IntValue;
-                x = x.ShiftRight(32);
-            }
-            return z;
-        }
-
         public static uint GetBit(uint[] x, int bit)
         {
             if (bit == 0)
diff --git a/crypto/src/math/raw/Nat192.cs b/crypto/src/math/raw/Nat192.cs
@@ -225,36 +225,6 @@ public static bool Eq64(ulong[] x, ulong[] y)
             return true;
         }
 
-        public static uint[] FromBigInteger(BigInteger x)
-        {
-            if (x.SignValue < 0 || x.BitLength > 192)
-                throw new ArgumentException();
-
-            uint[] z = Create();
-            int i = 0;
-            while (x.SignValue != 0)
-            {
-                z[i++] = (uint)x.IntValue;
-                x = x.ShiftRight(32);
-            }
-            return z;
-        }
-
-        public static ulong[] FromBigInteger64(BigInteger x)
-        {
-            if (x.SignValue < 0 || x.BitLength > 192)
-                throw new ArgumentException();
-
-            ulong[] z = Create64();
-            int i = 0;
-            while (x.SignValue != 0)
-            {
-                z[i++] = (ulong)x.LongValue;
-                x = x.ShiftRight(64);
-            }
-            return z;
-        }
-
         public static uint GetBit(uint[] x, int bit)
         {
             if (bit == 0)
diff --git a/crypto/src/math/raw/Nat224.cs b/crypto/src/math/raw/Nat224.cs
@@ -261,21 +261,6 @@ public static bool Eq(uint[] x, uint[] y)
             return true;
         }
 
-        public static uint[] FromBigInteger(BigInteger x)
-        {
-            if (x.SignValue < 0 || x.BitLength > 224)
-                throw new ArgumentException();
-
-            uint[] z = Create();
-            int i = 0;
-            while (x.SignValue != 0)
-            {
-                z[i++] = (uint)x.IntValue;
-                x = x.ShiftRight(32);
-            }
-            return z;
-        }
-
         public static uint GetBit(uint[] x, int bit)
         {
             if (bit == 0)
diff --git a/crypto/src/math/raw/Nat256.cs b/crypto/src/math/raw/Nat256.cs
@@ -323,36 +323,6 @@ public static bool Eq64(ulong[] x, ulong[] y)
             return true;
         }
 
-        public static uint[] FromBigInteger(BigInteger x)
-        {
-            if (x.SignValue < 0 || x.BitLength > 256)
-                throw new ArgumentException();
-
-            uint[] z = Create();
-            int i = 0;
-            while (x.SignValue != 0)
-            {
-                z[i++] = (uint)x.IntValue;
-                x = x.ShiftRight(32);
-            }
-            return z;
-        }
-
-        public static ulong[] FromBigInteger64(BigInteger x)
-        {
-            if (x.SignValue < 0 || x.BitLength > 256)
-                throw new ArgumentException();
-
-            ulong[] z = Create64();
-            int i = 0;
-            while (x.SignValue != 0)
-            {
-                z[i++] = (ulong)x.LongValue;
-                x = x.ShiftRight(64);
-            }
-            return z;
-        }
-
         public static uint GetBit(uint[] x, int bit)
         {
             if (bit == 0)
diff --git a/crypto/src/math/raw/Nat320.cs b/crypto/src/math/raw/Nat320.cs
@@ -47,21 +47,6 @@ public static bool Eq64(ulong[] x, ulong[] y)
             return true;
         }
 
-        public static ulong[] FromBigInteger64(BigInteger x)
-        {
-            if (x.SignValue < 0 || x.BitLength > 320)
-                throw new ArgumentException();
-
-            ulong[] z = Create64();
-            int i = 0;
-            while (x.SignValue != 0)
-            {
-                z[i++] = (ulong)x.LongValue;
-                x = x.ShiftRight(64);
-            }
-            return z;
-        }
-
         public static bool IsOne64(ulong[] x)
         {
             if (x[0] != 1UL)
diff --git a/crypto/src/math/raw/Nat448.cs b/crypto/src/math/raw/Nat448.cs
@@ -51,21 +51,6 @@ public static bool Eq64(ulong[] x, ulong[] y)
             return true;
         }
 
-        public static ulong[] FromBigInteger64(BigInteger x)
-        {
-            if (x.SignValue < 0 || x.BitLength > 448)
-                throw new ArgumentException();
-
-            ulong[] z = Create64();
-            int i = 0;
-            while (x.SignValue != 0)
-            {
-                z[i++] = (ulong)x.LongValue;
-                x = x.ShiftRight(64);
-            }
-            return z;
-        }
-
         public static bool IsOne64(ulong[] x)
         {
             if (x[0] != 1UL)
diff --git a/crypto/src/math/raw/Nat576.cs b/crypto/src/math/raw/Nat576.cs
@@ -55,21 +55,6 @@ public static bool Eq64(ulong[] x, ulong[] y)
             return true;
         }
 
-        public static ulong[] FromBigInteger64(BigInteger x)
-        {
-            if (x.SignValue < 0 || x.BitLength > 576)
-                throw new ArgumentException();
-
-            ulong[] z = Create64();
-            int i = 0;
-            while (x.SignValue != 0)
-            {
-                z[i++] = (ulong)x.LongValue;
-                x = x.ShiftRight(64);
-            }
-            return z;
-        }
-
         public static bool IsOne64(ulong[] x)
         {
             if (x[0] != 1UL)

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ public static void AddOne(uint[] x, uint[] z)`
`47`	`47`
`48`	`48`	`public static uint[] FromBigInteger(BigInteger x)`
`49`	`49`	`{`
`50`		`- uint[] z = Nat256.FromBigInteger(x);`
	`50`	`+ uint[] z = Nat.FromBigInteger(256, x);`
`51`	`51`	`while (Nat256.Gte(z, P))`
`52`	`52`	`{`
`53`	`53`	`Nat256.SubFrom(P, z);`
Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ public static void AddOne(uint[] x, uint[] z)`
`51`	`51`
`52`	`52`	`public static uint[] FromBigInteger(BigInteger x)`
`53`	`53`	`{`
`54`		`- uint[] z = Nat160.FromBigInteger(x);`
	`54`	`+ uint[] z = Nat.FromBigInteger(160, x);`
`55`	`55`	`if (z[4] == P4 && Nat160.Gte(z, P))`
`56`	`56`	`{`
`57`	`57`	`Nat160.SubFrom(P, z);`
Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ public static void AddOne(uint[] x, uint[] z)`
`52`	`52`
`53`	`53`	`public static uint[] FromBigInteger(BigInteger x)`
`54`	`54`	`{`
`55`		`- uint[] z = Nat192.FromBigInteger(x);`
	`55`	`+ uint[] z = Nat.FromBigInteger(192, x);`
`56`	`56`	`if (z[5] == P5 && Nat192.Gte(z, P))`
`57`	`57`	`{`
`58`	`58`	`Nat192.SubFrom(P, z);`
Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ public static void AddOne(uint[] x, uint[] z)`
`53`	`53`
`54`	`54`	`public static uint[] FromBigInteger(BigInteger x)`
`55`	`55`	`{`
`56`		`- uint[] z = Nat224.FromBigInteger(x);`
	`56`	`+ uint[] z = Nat.FromBigInteger(224, x);`
`57`	`57`	`if (z[6] == P6 && Nat224.Gte(z, P))`
`58`	`58`	`{`
`59`	`59`	`Nat224.SubFrom(P, z);`