Remove unnecessary locking

peterdettman · peterdettman · commit c11e0f9da00f · 2020-09-04T15:31:54.000+07:00
- see bcgit/bc-java#778
diff --git a/crypto/src/math/ec/ECCurve.cs b/crypto/src/math/ec/ECCurve.cs
@@ -433,18 +433,17 @@ public virtual ECEndomorphism GetEndomorphism()
         }
 
         /**
-         * Sets the default <code>ECMultiplier</code>, unless already set. 
+         * Sets the default <code>ECMultiplier</code>, unless already set.
+         *
+         * We avoid locking for performance reasons, so there is no uniqueness guarantee.
          */
         public virtual ECMultiplier GetMultiplier()
         {
-            lock (this)
+            if (this.m_multiplier == null)
             {
-                if (this.m_multiplier == null)
-                {
-                    this.m_multiplier = CreateDefaultMultiplier();
-                }
-                return this.m_multiplier;
+                this.m_multiplier = CreateDefaultMultiplier();
             }
+            return this.m_multiplier;
         }
 
         /**

Original file line number	Diff line number	Diff line change
`@@ -433,18 +433,17 @@ public virtual ECEndomorphism GetEndomorphism()`
`433`	`433`	`}`
`434`	`434`
`435`	`435`	`/**`
`436`		`- * Sets the default <code>ECMultiplier</code>, unless already set.`
	`436`	`+ * Sets the default <code>ECMultiplier</code>, unless already set.`
	`437`	`+ *`
	`438`	`+ * We avoid locking for performance reasons, so there is no uniqueness guarantee.`
`437`	`439`	`*/`
`438`	`440`	`public virtual ECMultiplier GetMultiplier()`
`439`	`441`	`{`
`440`		`- lock (this)`
	`442`	`+ if (this.m_multiplier == null)`
`441`	`443`	`{`
`442`		`- if (this.m_multiplier == null)`
`443`		`- {`
`444`		`- this.m_multiplier = CreateDefaultMultiplier();`
`445`		`- }`
`446`		`- return this.m_multiplier;`
	`444`	`+ this.m_multiplier = CreateDefaultMultiplier();`
`447`	`445`	`}`
	`446`	`+ return this.m_multiplier;`
`448`	`447`	`}`
`449`	`448`
`450`	`449`	`/**`