Remove SecretSplitter.recombineShares

Author: gefeili

core/src/main/java/org/bouncycastle/crypto/threshold/SecretSplitter.java

@@ -13,13 +13,4 @@ public interface SecretSplitter
      * @return An array of {@code byte[][]} representing the generated secret shares for m users with l bytes each.
      */
     SplitSecret split();
-
-    /**
-     * Recombines secret shares to reconstruct the original secret.
-     *
-     * @param rr The threshold number of shares required for recombination.
-     * @param splits A vector of byte arrays representing the shares, where each share is l bytes long.
-     * @return A byte array containing the reconstructed secret.
-     */
-    byte[] recombineShares(int[] rr, byte[]... splits);
 }

core/src/main/java/org/bouncycastle/crypto/threshold/ShamirSecretSplitter.java

@@ -17,7 +17,7 @@ public enum Mode
         Table
     }
 
-    private Polynomial poly;
+    private final Polynomial poly;
     /**
      * Length of the secret
      */
@@ -78,32 +78,4 @@ public ShamirSplitSecret split()
         }
         return new ShamirSplitSecret(poly, secretShares);
     }
-
-    public byte[] recombineShares(int[] rr, byte[]... splits)
-    {
-        int n = rr.length;
-        byte[] r = new byte[n];
-        byte tmp;
-        byte[] products = new byte[n - 1];
-        for (int i = 0; i < n; i++)
-        {
-            tmp = 0;
-            for (int j = 0; j < n; j++)
-            {
-                if (j != i)
-                {
-                    products[tmp++] = poly.gfDiv(rr[j], rr[i] ^ rr[j]);
-                }
-            }
-
-            tmp = 1;
-            for (byte p : products)
-            {
-                tmp = (byte)poly.gfMul(tmp & 0xff, p & 0xff);
-            }
-            r[i] = tmp;
-        }
-
-        return poly.gfVecMul(r, splits);
-    }
 }

core/src/main/java/org/bouncycastle/crypto/threshold/SplitSecret.java

@@ -4,5 +4,10 @@ public interface SplitSecret
 {
     SecretShare[] getSecretShare();
 
+    /**
+     * Recombines secret shares to reconstruct the original secret.
+     *
+     * @return A byte array containing the reconstructed secret.
+     */
     byte[] recombine();
 }