Skip to content

Commit 19145af

Browse files
committed
Refactor unnecessary special cases
1 parent 5765733 commit 19145af

File tree

1 file changed

+4
-10
lines changed

1 file changed

+4
-10
lines changed

pkix/src/main/java/org/bouncycastle/operator/DefaultDigestAlgorithmIdentifierFinder.java

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -190,6 +190,10 @@ public class DefaultDigestAlgorithmIdentifierFinder
190190
digestOids.put(X509ObjectIdentifiers.id_ecdsa_with_shake128, NISTObjectIdentifiers.id_shake128);
191191
digestOids.put(X509ObjectIdentifiers.id_ecdsa_with_shake256, NISTObjectIdentifiers.id_shake256);
192192

193+
digestOids.put(EdECObjectIdentifiers.id_Ed25519, NISTObjectIdentifiers.id_sha512);
194+
195+
digestOids.put(PKCSObjectIdentifiers.id_alg_hss_lms_hashsig, NISTObjectIdentifiers.id_sha256);
196+
193197
digestNameToOids.put("SHA-1", OIWObjectIdentifiers.idSHA1);
194198
digestNameToOids.put("SHA-224", NISTObjectIdentifiers.id_sha224);
195199
digestNameToOids.put("SHA-256", NISTObjectIdentifiers.id_sha256);
@@ -245,8 +249,6 @@ public class DefaultDigestAlgorithmIdentifierFinder
245249
addDigestAlgId(NISTObjectIdentifiers.id_sha3_256, false);
246250
addDigestAlgId(NISTObjectIdentifiers.id_sha3_384, false);
247251
addDigestAlgId(NISTObjectIdentifiers.id_sha3_512, false);
248-
249-
// RFC 8702
250252
addDigestAlgId(NISTObjectIdentifiers.id_shake128, false);
251253
addDigestAlgId(NISTObjectIdentifiers.id_shake256, false);
252254

@@ -317,14 +319,6 @@ public AlgorithmIdentifier find(AlgorithmIdentifier sigAlgId)
317319
{
318320
digAlgOid = RSASSAPSSparams.getInstance(sigAlgId.getParameters()).getHashAlgorithm().getAlgorithm();
319321
}
320-
else if (sigAlgOid.equals(EdECObjectIdentifiers.id_Ed25519))
321-
{
322-
digAlgOid = NISTObjectIdentifiers.id_sha512;
323-
}
324-
else if (sigAlgOid.equals(PKCSObjectIdentifiers.id_alg_hss_lms_hashsig))
325-
{
326-
digAlgOid = NISTObjectIdentifiers.id_sha256;
327-
}
328322
else
329323
{
330324
digAlgOid = (ASN1ObjectIdentifier)digestOids.get(sigAlgOid);

0 commit comments

Comments
 (0)