Skip to content

Commit 214991d

Browse files
author
gefeili
committed
Pass key generation of Snova.
1 parent 8fe3792 commit 214991d

File tree

2 files changed

+19
-17
lines changed

2 files changed

+19
-17
lines changed

core/src/main/java/org/bouncycastle/pqc/crypto/snova/SnovaKeyPairGenerator.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,8 +212,10 @@ private void genABQP(MapGroup1 map1, byte[] pkSeed, byte[] fixedAbq)
212212
}
213213
else
214214
{
215-
//TODO: fixedAbq fill more than aAlpha. bAlpha should be filled as well
216215
MapGroup1.fillAlpha(fixedAbq, 0, map1.aAlpha, m * o * alpha * lsq);
216+
MapGroup1.fillAlpha(fixedAbq, o * alpha * lsq, map1.bAlpha, (m - 1) * o * alpha * lsq);
217+
MapGroup1.fillAlpha(fixedAbq, o * alpha * lsq * 2, map1.qAlpha1, (m - 2) * o * alpha * lsq);
218+
MapGroup1.fillAlpha(fixedAbq, o * alpha * lsq * 3, map1.qAlpha2, (m - 3) * o * alpha * lsq);
217219
}
218220
}
219221

core/src/test/java/org/bouncycastle/pqc/crypto/test/SnovaTest.java

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -27,14 +27,14 @@ public static void main(String[] args)
2727

2828
private static final SnovaParameters[] PARAMETER_SETS = new SnovaParameters[]
2929
{
30-
// SnovaParameters.SNOVA_24_5_16_4_ESK,
31-
// SnovaParameters.SNOVA_24_5_16_4_SHAKE_ESK,
32-
// SnovaParameters.SNOVA_24_5_16_4_SHAKE_SSK,
33-
// SnovaParameters.SNOVA_24_5_16_4_SSK,
34-
// SnovaParameters.SNOVA_24_5_16_5_ESK,
35-
// SnovaParameters.SNOVA_24_5_16_5_SHAKE_ESK,
36-
// SnovaParameters.SNOVA_24_5_16_5_SHAKE_SSK,
37-
// SnovaParameters.SNOVA_24_5_16_5_SSK,
30+
SnovaParameters.SNOVA_24_5_16_4_ESK,
31+
SnovaParameters.SNOVA_24_5_16_4_SHAKE_ESK,
32+
SnovaParameters.SNOVA_24_5_16_4_SHAKE_SSK,
33+
SnovaParameters.SNOVA_24_5_16_4_SSK,
34+
SnovaParameters.SNOVA_24_5_16_5_ESK,
35+
SnovaParameters.SNOVA_24_5_16_5_SHAKE_ESK,
36+
SnovaParameters.SNOVA_24_5_16_5_SHAKE_SSK,
37+
SnovaParameters.SNOVA_24_5_16_5_SSK,
3838
SnovaParameters.SNOVA_25_8_16_3_ESK,
3939
SnovaParameters.SNOVA_25_8_16_3_SHAKE_ESK,
4040
SnovaParameters.SNOVA_25_8_16_3_SHAKE_SSK,
@@ -74,14 +74,14 @@ public static void main(String[] args)
7474
};
7575

7676
private static final String[] files = new String[]{
77-
// "PQCsignKAT_SNOVA_24_5_4_ESK.rsp",
78-
// "PQCsignKAT_SNOVA_24_5_4_SHAKE_ESK.rsp",
79-
// "PQCsignKAT_SNOVA_24_5_4_SHAKE_SSK.rsp",
80-
// "PQCsignKAT_SNOVA_24_5_4_SSK.rsp",
81-
// "PQCsignKAT_SNOVA_24_5_5_ESK.rsp",
82-
// "PQCsignKAT_SNOVA_24_5_5_SHAKE_ESK.rsp",
83-
// "PQCsignKAT_SNOVA_24_5_5_SHAKE_SSK.rsp",
84-
// "PQCsignKAT_SNOVA_24_5_5_SSK.rsp",
77+
"PQCsignKAT_SNOVA_24_5_4_ESK.rsp",
78+
"PQCsignKAT_SNOVA_24_5_4_SHAKE_ESK.rsp",
79+
"PQCsignKAT_SNOVA_24_5_4_SHAKE_SSK.rsp",
80+
"PQCsignKAT_SNOVA_24_5_4_SSK.rsp",
81+
"PQCsignKAT_SNOVA_24_5_5_ESK.rsp",
82+
"PQCsignKAT_SNOVA_24_5_5_SHAKE_ESK.rsp",
83+
"PQCsignKAT_SNOVA_24_5_5_SHAKE_SSK.rsp",
84+
"PQCsignKAT_SNOVA_24_5_5_SSK.rsp",
8585
"PQCsignKAT_SNOVA_25_8_3_ESK.rsp",
8686
"PQCsignKAT_SNOVA_25_8_3_SHAKE_ESK.rsp",
8787
"PQCsignKAT_SNOVA_25_8_3_SHAKE_SSK.rsp",

0 commit comments

Comments
 (0)