ErrorProne fixes.

Author: dghgit

core/src/main/java/org/bouncycastle/math/ec/custom/sec/SecT571K1Point.java

@@ -7,6 +7,7 @@
 import org.bouncycastle.math.ec.ECPoint.AbstractF2m;
 import org.bouncycastle.math.raw.Nat576;
 
+@SuppressWarnings("AssignmentExpression")
 public class SecT571K1Point extends AbstractF2m
 {
     SecT571K1Point(ECCurve curve, ECFieldElement x, ECFieldElement y)
@@ -58,7 +59,7 @@ protected boolean getCompressionYTilde()
         // Y is actually Lambda (X + Y/X) here
         return Y.testBitZero() != X.testBitZero();
     }
-
+    
     public ECPoint add(ECPoint b)
     {
         if (this.isInfinity())

core/src/main/java/org/bouncycastle/math/ec/custom/sec/SecT571R1Point.java

@@ -8,6 +8,7 @@
 import org.bouncycastle.math.raw.Nat;
 import org.bouncycastle.math.raw.Nat576;
 
+@SuppressWarnings("AssignmentExpression")
 public class SecT571R1Point extends AbstractF2m
 {
     SecT571R1Point(ECCurve curve, ECFieldElement x, ECFieldElement y)

pkix/src/main/java/org/bouncycastle/cert/ocsp/BasicOCSPRespBuilder.java

@@ -43,7 +43,7 @@ private static class ResponseObject
         ASN1GeneralizedTime   nextUpdate;
         Extensions        extensions;
 
-        public ResponseObject(
+        ResponseObject(
             CertificateID     certId,
             CertificateStatus certStatus,
             Date              thisUpdate,
@@ -90,7 +90,7 @@ else if (certStatus instanceof UnknownStatus)
             this.extensions = extensions;
         }
 
-        public SingleResponse toResponse()
+        SingleResponse toResponse()
             throws Exception
         {
             return new SingleResponse(certId.toASN1Primitive(), certStatus, thisUpdate, nextUpdate, extensions);

pkix/src/main/java/org/bouncycastle/cert/ocsp/OCSPReqBuilder.java

@@ -31,15 +31,15 @@ private static class RequestObject
         CertificateID   certId;
         Extensions  extensions;
 
-        public RequestObject(
+        RequestObject(
             CertificateID   certId,
             Extensions  extensions)
         {
             this.certId = certId;
             this.extensions = extensions;
         }
 
-        public Request toRequest()
+        Request toRequest()
             throws Exception
         {
             return new Request(certId.toASN1Primitive(), extensions);

pkix/src/main/java/org/bouncycastle/cert/selector/MSOutlookKeyIdCalculator.java

@@ -44,7 +44,7 @@ private static abstract class GeneralDigest
         /**
          * Standard constructor
          */
-        protected GeneralDigest()
+        GeneralDigest()
         {
             xBuf = new byte[4];
             xBufOff = 0;
@@ -55,22 +55,22 @@ protected GeneralDigest()
          * of the Object.clone() interface as this interface is not
          * supported by J2ME.
          */
-        protected GeneralDigest(GeneralDigest t)
+        GeneralDigest(GeneralDigest t)
         {
             xBuf = new byte[t.xBuf.length];
 
             copyIn(t);
         }
 
-        protected void copyIn(GeneralDigest t)
+        void copyIn(GeneralDigest t)
         {
             System.arraycopy(t.xBuf, 0, xBuf, 0, t.xBuf.length);
 
             xBufOff = t.xBufOff;
             byteCount = t.byteCount;
         }
 
-        public void update(
+        void update(
             byte in)
         {
             xBuf[xBufOff++] = in;
@@ -84,7 +84,7 @@ public void update(
             byteCount++;
         }
 
-        public void update(
+        void update(
             byte[]  in,
             int     inOff,
             int     len)
@@ -124,7 +124,7 @@ public void update(
             }
         }
 
-        public void finish()
+        void finish()
         {
             long    bitLength = (byteCount << 3);
 
@@ -143,7 +143,7 @@ public void finish()
             processBlock();
         }
 
-        public void reset()
+        void reset()
         {
             byteCount = 0;
 
@@ -154,11 +154,11 @@ public void reset()
             }
         }
 
-        protected abstract void processWord(byte[] in, int inOff);
+        abstract void processWord(byte[] in, int inOff);
 
-        protected abstract void processLength(long bitLength);
+        abstract void processLength(long bitLength);
 
-        protected abstract void processBlock();
+        abstract void processBlock();
     }
 
     private static class SHA1Digest
@@ -174,22 +174,22 @@ private static class SHA1Digest
         /**
          * Standard constructor
          */
-        public SHA1Digest()
+        SHA1Digest()
         {
             reset();
         }
 
-        public String getAlgorithmName()
+        String getAlgorithmName()
         {
             return "SHA-1";
         }
 
-        public int getDigestSize()
+        int getDigestSize()
         {
             return DIGEST_LENGTH;
         }
 
-        protected void processWord(
+        void processWord(
             byte[]  in,
             int     inOff)
         {
@@ -207,7 +207,7 @@ protected void processWord(
             }
         }
 
-        protected void processLength(
+        void processLength(
             long    bitLength)
         {
             if (xOff > 14)
@@ -219,7 +219,7 @@ protected void processLength(
             X[15] = (int)(bitLength & 0xffffffff);
         }
 
-        public int doFinal(
+        int doFinal(
             byte[]  out,
             int     outOff)
         {
@@ -239,7 +239,7 @@ public int doFinal(
         /**
          * reset the chaining variables
          */
-        public void reset()
+        void reset()
         {
             super.reset();
 
@@ -288,7 +288,7 @@ private int g(
             return ((u & v) | (u & w) | (v & w));
         }
 
-        protected void processBlock()
+        void processBlock()
         {
             //
             // expand 16 word block into 80 word block.