Skip to content

Commit 316c2a4

Browse files
committed
removed dependency on PQC PublicKeyFactory.
1 parent 8756876 commit 316c2a4

File tree

3 files changed

+4
-12
lines changed

3 files changed

+4
-12
lines changed

core/src/main/java/org/bouncycastle/crypto/util/PublicKeyFactory.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -165,8 +165,7 @@ public static AsymmetricKeyParameter createKey(SubjectPublicKeyInfo keyInfo, Obj
165165
SubjectPublicKeyInfoConverter converter = (SubjectPublicKeyInfoConverter)converters.get(algID.getAlgorithm());
166166
if (null == converter)
167167
{
168-
return org.bouncycastle.pqc.crypto.util.PublicKeyFactory.createKey(keyInfo, defaultParams);
169-
//throw new IOException("algorithm identifier in public key not recognised: " + algID.getAlgorithm());
168+
throw new IOException("algorithm identifier in public key not recognised: " + algID.getAlgorithm());
170169
}
171170

172171
return converter.getPublicKeyParameters(keyInfo, defaultParams);

pkix/src/main/java/org/bouncycastle/operator/bc/BcHssLmsContentVerifierProviderBuilder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
import org.bouncycastle.asn1.x509.SubjectPublicKeyInfo;
77
import org.bouncycastle.crypto.Signer;
88
import org.bouncycastle.crypto.params.AsymmetricKeyParameter;
9-
import org.bouncycastle.crypto.util.PublicKeyFactory;
109
import org.bouncycastle.operator.OperatorCreationException;
10+
import org.bouncycastle.pqc.crypto.util.PublicKeyFactory;
1111

1212
/**
1313
* Builder for creating content verifier providers that support the HSS/LMS Hash-Based Signature Algorithm.

pkix/src/test/java/org/bouncycastle/cms/test/PQCSignedDataTest.java

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -52,18 +52,11 @@
5252
import org.bouncycastle.cms.jcajce.JcaSimpleSignerInfoVerifierBuilder;
5353
import org.bouncycastle.crypto.AsymmetricCipherKeyPair;
5454
import org.bouncycastle.crypto.AsymmetricCipherKeyPairGenerator;
55-
import org.bouncycastle.crypto.generators.DSAKeyPairGenerator;
56-
import org.bouncycastle.crypto.generators.DSAParametersGenerator;
5755
import org.bouncycastle.crypto.params.AsymmetricKeyParameter;
58-
import org.bouncycastle.crypto.params.DSAKeyGenerationParameters;
59-
import org.bouncycastle.crypto.params.DSAParameters;
60-
import org.bouncycastle.crypto.util.PublicKeyFactory;
6156
import org.bouncycastle.jce.provider.BouncyCastleProvider;
6257
import org.bouncycastle.operator.ContentSigner;
6358
import org.bouncycastle.operator.DigestCalculatorProvider;
6459
import org.bouncycastle.operator.OperatorCreationException;
65-
import org.bouncycastle.operator.bc.BcDSAContentSignerBuilder;
66-
import org.bouncycastle.operator.bc.BcDSAContentVerifierProviderBuilder;
6760
import org.bouncycastle.operator.bc.BcHssLmsContentSignerBuilder;
6861
import org.bouncycastle.operator.bc.BcHssLmsContentVerifierProviderBuilder;
6962
import org.bouncycastle.operator.jcajce.JcaContentSignerBuilder;
@@ -444,7 +437,7 @@ public void testCheckCreationHss()
444437

445438
assertTrue(cert.isSignatureValid(new BcHssLmsContentVerifierProviderBuilder().build(pubKey)));
446439

447-
AsymmetricKeyParameter certPubKey = PublicKeyFactory.createKey(cert.getSubjectPublicKeyInfo());
440+
AsymmetricKeyParameter certPubKey = org.bouncycastle.pqc.crypto.util.PublicKeyFactory.createKey(cert.getSubjectPublicKeyInfo());
448441

449442
assertTrue(cert.isSignatureValid(new BcHssLmsContentVerifierProviderBuilder().build(certPubKey)));
450443

@@ -517,7 +510,7 @@ public void testCheckCreationLms()
517510

518511
assertTrue(cert.isSignatureValid(new BcHssLmsContentVerifierProviderBuilder().build(pubKey)));
519512

520-
AsymmetricKeyParameter certPubKey = ((HSSPublicKeyParameters)PublicKeyFactory.createKey(cert.getSubjectPublicKeyInfo())).getLMSPublicKey();
513+
AsymmetricKeyParameter certPubKey = ((HSSPublicKeyParameters)org.bouncycastle.pqc.crypto.util.PublicKeyFactory.createKey(cert.getSubjectPublicKeyInfo())).getLMSPublicKey();
521514

522515
assertTrue(cert.isSignatureValid(new BcHssLmsContentVerifierProviderBuilder().build(certPubKey)));
523516

0 commit comments

Comments
 (0)