Skip to content

Commit 3910287

Browse files
committed
removed use of junit.Assert.
1 parent 3630658 commit 3910287

File tree

2 files changed

+12
-17
lines changed

2 files changed

+12
-17
lines changed

core/src/test/java/org/bouncycastle/crypto/threshold/test/AllTests.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
import junit.framework.Test;
55
import junit.framework.TestCase;
66
import junit.framework.TestSuite;
7-
87
import org.bouncycastle.test.PrintTestResult;
98

109
public class AllTests

core/src/test/java/org/bouncycastle/crypto/threshold/test/ShamirSecretSplitterTest.java

Lines changed: 12 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -3,17 +3,13 @@
33
import java.io.IOException;
44
import java.security.SecureRandom;
55

6-
76
import junit.framework.TestCase;
8-
97
import org.bouncycastle.crypto.threshold.ShamirSecretSplitter;
108
import org.bouncycastle.crypto.threshold.ShamirSplitSecret;
119
import org.bouncycastle.crypto.threshold.ShamirSplitSecretShare;
10+
import org.bouncycastle.util.Arrays;
1211
import org.bouncycastle.util.encoders.Hex;
1312
import org.bouncycastle.util.test.FixedSecureRandom;
14-
import org.bouncycastle.util.Arrays;
15-
16-
import org.junit.Assert;
1713

1814
public class ShamirSecretSplitterTest
1915
extends TestCase
@@ -59,8 +55,8 @@ public void testShamirSecretResplit()
5955
byte[] secret3 = splitSecret3.getSecret();
6056

6157

62-
Assert.assertArrayEquals(secret1, secret3);
63-
Assert.assertFalse(Arrays.areEqual(Arrays.concatenate(secretShares[0].getEncoded(), secretShares[1].getEncoded(), secretShares[2].getEncoded()),
58+
assertTrue(Arrays.areEqual(secret1, secret3));
59+
assertFalse(Arrays.areEqual(Arrays.concatenate(secretShares[0].getEncoded(), secretShares[1].getEncoded(), secretShares[2].getEncoded()),
6460
Arrays.concatenate(secretShares2[0].getEncoded(), secretShares2[1].getEncoded(), secretShares2[2].getEncoded())));
6561
}
6662

@@ -93,14 +89,14 @@ public void testShamirSecretMultipleDivide()
9389
ShamirSplitSecret splitSecret2 = new ShamirSplitSecret(algorithm, mode, secretShares2);
9490
byte[] secret2 = splitSecret2.getSecret();
9591

96-
Assert.assertArrayEquals(secret1, secret2);
92+
assertTrue(Arrays.areEqual(secret1, secret2));
9793

9894

9995
// not enough secret shares cannot correctly recover the secret
10096
ShamirSplitSecretShare[] secretShares3 = new ShamirSplitSecretShare[]{secretShares[3], secretShares[6]};
10197
ShamirSplitSecret splitSecret3 = new ShamirSplitSecret(algorithm, mode, secretShares3);
10298
byte[] secret3 = splitSecret3.getSecret();
103-
Assert.assertFalse(Arrays.areEqual(secret1, secret3));
99+
assertFalse(Arrays.areEqual(secret1, secret3));
104100
}
105101

106102
public void testShamirSecretSplitterSplitAround()
@@ -118,7 +114,7 @@ public void testShamirSecretSplitterSplitAround()
118114
ShamirSplitSecretShare ss = new ShamirSplitSecretShare(seed);
119115
ShamirSplitSecret splitSecret = splitter.splitAround(ss, m, n);
120116
ShamirSplitSecretShare[] secretShares = splitSecret.getSecretShares();
121-
Assert.assertArrayEquals(secretShares[0].getEncoded(), seed);
117+
assertTrue(Arrays.areEqual(secretShares[0].getEncoded(), seed));
122118

123119
ShamirSplitSecretShare[] secretShares1 = new ShamirSplitSecretShare[]{secretShares[0], secretShares[1], secretShares[2]};
124120
ShamirSplitSecret splitSecret1 = new ShamirSplitSecret(algorithm, mode, secretShares1);
@@ -132,19 +128,19 @@ public void testShamirSecretSplitterSplitAround()
132128
ShamirSplitSecret splitSecret2 = new ShamirSplitSecret(algorithm, mode, secretShares2);
133129
byte[] secret2 = splitSecret2.getSecret();
134130

135-
Assert.assertArrayEquals(secret1, secret2);
136-
Assert.assertArrayEquals(secret1, secret4);
131+
assertTrue(Arrays.areEqual(secret1, secret2));
132+
assertTrue(Arrays.areEqual(secret1, secret4));
137133

138134
// not enough secret shares cannot correctly recover the secret
139135
ShamirSplitSecretShare[] secretShares3 = new ShamirSplitSecretShare[]{secretShares[3], secretShares[6]};
140136
ShamirSplitSecret splitSecret3 = new ShamirSplitSecret(algorithm, mode, secretShares3);
141137
byte[] secret3 = splitSecret3.getSecret();
142-
Assert.assertFalse(Arrays.areEqual(secret1, secret3));
138+
assertFalse(Arrays.areEqual(secret1, secret3));
143139

144140
secretShares3 = new ShamirSplitSecretShare[]{secretShares[0], secretShares[1]};
145141
splitSecret3 = new ShamirSplitSecret(algorithm, mode, secretShares3);
146142
secret3 = splitSecret3.getSecret();
147-
Assert.assertFalse(Arrays.areEqual(secret1, secret3));
143+
assertFalse(Arrays.areEqual(secret1, secret3));
148144
}
149145

150146
public void testShamirSecretSplitter()
@@ -165,13 +161,13 @@ public void testShamirSecretSplitter()
165161
ShamirSplitSecret splitSecret2 = new ShamirSplitSecret(algorithm, mode, secretShares2);
166162
byte[] secret2 = splitSecret2.getSecret();
167163

168-
Assert.assertArrayEquals(secret1, secret2);
164+
assertTrue(Arrays.areEqual(secret1, secret2));
169165

170166
// not enough secret shares cannot correctly recover the secret
171167
ShamirSplitSecretShare[] secretShares3 = new ShamirSplitSecretShare[]{secretShares[3], secretShares[6]};
172168
ShamirSplitSecret splitSecret3 = new ShamirSplitSecret(algorithm, mode, secretShares3);
173169
byte[] secret3 = splitSecret3.getSecret();
174-
Assert.assertFalse(Arrays.areEqual(secret1, secret3));
170+
assertFalse(Arrays.areEqual(secret1, secret3));
175171
}
176172
// private static Polynomial polynomial1 = new PolynomialTable(Polynomial.AES);
177173
// private static Polynomial polynomial2 = new PolynomialTable(Polynomial.RSA);

0 commit comments

Comments
 (0)