change new BigInteger(n, random) to BigIntegers.createRandomBigInteger

Author: gefeili

core/src/main/java/org/bouncycastle/crypto/generators/ECCSIKeyPairGenerator.java

@@ -14,6 +14,7 @@
 import org.bouncycastle.crypto.params.ECCSIPrivateKeyParameters;
 import org.bouncycastle.crypto.params.ECCSIPublicKeyParameters;
 import org.bouncycastle.math.ec.ECPoint;
+import org.bouncycastle.util.BigIntegers;
 
 /**
  * A key pair generator for the ECCSI scheme (Elliptic Curve-based Certificateless Signatures
@@ -57,7 +58,7 @@ public AsymmetricCipherKeyPair generateKeyPair()
         byte[] id = parameters.getId();
         ECPoint kpak = parameters.getKPAK();
         // 1) Choose v, a random (ephemeral) non-zero element of F_q;
-        BigInteger v = new BigInteger(256, random).mod(q);
+        BigInteger v = BigIntegers.createRandomBigInteger(256, random).mod(q);
         // 2) Compute PVT = [v]G
         ECPoint pvt = G.multiply(v).normalize();
 

core/src/main/java/org/bouncycastle/crypto/kems/SAKKEKEMSGenerator.java

@@ -78,7 +78,7 @@ public SecretWithEncapsulation generateEncapsulated(AsymmetricKeyParameter recip
         Digest digest = keyParameters.getDigest();
 
         // 1. Generate random SSV in range [0, 2^n - 1]
-        BigInteger ssv = new BigInteger(n, random);
+        BigInteger ssv = BigIntegers.createRandomBigInteger(n, random);
 
         // 2. Compute r = HashToIntegerRange(SSV || b, q)
         BigInteger r = hashToIntegerRange(Arrays.concatenate(ssv.toByteArray(), b.toByteArray()), q, digest);

core/src/main/java/org/bouncycastle/crypto/params/ECCSIKeyGenerationParameters.java

@@ -8,6 +8,7 @@
 import org.bouncycastle.crypto.KeyGenerationParameters;
 import org.bouncycastle.math.ec.ECPoint;
 import org.bouncycastle.util.Arrays;
+import org.bouncycastle.util.BigIntegers;
 
 /**
  * Parameters for ECCSI key generation.
@@ -80,7 +81,7 @@ public ECCSIKeyGenerationParameters(SecureRandom random, X9ECParameters params,
         this.digest = digest;
         this.id = Arrays.clone(id);
         this.n = params.getCurve().getA().bitLength();
-        this.ksak = new BigInteger(n, random).mod(q);
+        this.ksak = BigIntegers.createRandomBigInteger(n, random).mod(q);
         this.kpak = G.multiply(ksak).normalize();
     }
 

core/src/main/java/org/bouncycastle/crypto/signers/ECCSISigner.java

@@ -189,7 +189,7 @@ public void reset()
         {
             ECCSIPrivateKeyParameters parameters = (ECCSIPrivateKeyParameters)param;
             pvt = parameters.getPublicKeyParameters().getPVT();
-            j = new BigInteger(q.bitLength(), random);
+            j = BigIntegers.createRandomBigInteger(q.bitLength(), random);
             ECPoint J = G.multiply(j).normalize();
             r = J.getAffineXCoord().toBigInteger().mod(q);