Skip to content

Commit 6e801d1

Browse files
author
gefeili
committed
Fix the bug in ShamirSecretSplitterTest.testShamirSecretMultipleDivide that mul may be 0.
1 parent 12bf4c2 commit 6e801d1

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

core/src/test/java/org/bouncycastle/crypto/threshold/test/ShamirSecretSplitterTest.java

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,12 @@ public static void main(String[] args)
1919
throws IOException
2020
{
2121
ShamirSecretSplitterTest test = new ShamirSecretSplitterTest();
22+
for (int i = 0; i < 1000; ++i)
23+
{
24+
test.testShamirSecretMultipleDivide();
25+
}
2226
test.performTest();
27+
System.out.println("OK");
2328
}
2429

2530
public void performTest()
@@ -77,7 +82,7 @@ public void testShamirSecretMultipleDivide()
7782
ShamirSplitSecret splitSecret1 = new ShamirSplitSecret(algorithm, mode, secretShares1);
7883
byte[] secret1 = splitSecret1.getSecret();
7984

80-
int mul = random.nextInt(255);
85+
int mul = random.nextInt(254) + 1;
8186
splitSecret.multiple(mul);
8287
secretShares = (ShamirSplitSecretShare[])splitSecret.getSecretShares();
8388
ShamirSplitSecretShare[] secretShares4 = new ShamirSplitSecretShare[]{secretShares[1], secretShares[2], secretShares[5]};
@@ -89,7 +94,6 @@ public void testShamirSecretMultipleDivide()
8994
ShamirSplitSecretShare[] secretShares2 = new ShamirSplitSecretShare[]{secretShares[4], secretShares[7], secretShares[8]};
9095
ShamirSplitSecret splitSecret2 = new ShamirSplitSecret(algorithm, mode, secretShares2);
9196
byte[] secret2 = splitSecret2.getSecret();
92-
9397
assertTrue(Arrays.areEqual(secret1, secret2));
9498

9599

@@ -966,7 +970,7 @@ public ShamirSplitSecret newInstance(ShamirSplitSecretShare[] secretShares)
966970
@Override
967971
public ShamirSecretSplitter newInstance(int l, int m, int n, SecureRandom random)
968972
{
969-
return new ShamirSecretSplitter(ShamirSecretSplitter.Algorithm.AES, ShamirSecretSplitter.Mode.Table, l, random);
973+
return new ShamirSecretSplitter(ShamirSecretSplitter.Algorithm.AES, ShamirSecretSplitter.Mode.Table, l, random);
970974
}
971975

972976
@Override
@@ -996,7 +1000,7 @@ public ShamirSplitSecret newInstance(ShamirSplitSecretShare[] secretShares)
9961000
@Override
9971001
public ShamirSecretSplitter newInstance(int l, int m, int n, SecureRandom random)
9981002
{
999-
return new ShamirSecretSplitter(ShamirSecretSplitter.Algorithm.RSA, ShamirSecretSplitter.Mode.Table, l,random);
1003+
return new ShamirSecretSplitter(ShamirSecretSplitter.Algorithm.RSA, ShamirSecretSplitter.Mode.Table, l, random);
10001004
}
10011005

10021006
@Override

0 commit comments

Comments
 (0)