TODO finish copyTo in MapGroup1 and replace MapGroup1.encodeP in line 482 of SnoveEngine.

Author: gefeili

core/src/main/java/org/bouncycastle/pqc/crypto/snova/GF16Utils.java

@@ -117,7 +117,7 @@ public static void encodeMergeInHalf(byte[] m, int mlen, byte[] menc)
         // If there is an extra nibble (odd number of nibbles), store it directly in lower 4 bits.
         if ((mlen & 1) == 1)
         {
-            menc[i] = (byte)m[i];
+            menc[i] = m[i];
         }
     }
 

core/src/main/java/org/bouncycastle/pqc/crypto/snova/MapGroup1.java

@@ -74,6 +74,8 @@ private static int fillAlpha(byte[] input, int inOff, byte[][][] alpha, int len)
         return rlt;
     }
 
+    //private static void copyTo(byte[][][] al)
+
 
 //    static int decodeP(byte[] input, int inOff, byte[][][][] p, int len)
 //    {

core/src/main/java/org/bouncycastle/pqc/crypto/snova/SnovaKeyElements.java

@@ -6,7 +6,7 @@ class SnovaKeyElements
     public final byte[][][] T12;     // [v][o]
     public final MapGroup2 map2;
     public final PublicKey publicKey;
-    private int length;
+    private final int length;
 
     public SnovaKeyElements(SnovaParameters params)
     {

core/src/main/java/org/bouncycastle/pqc/crypto/snova/SnovaKeyPairGenerator.java

@@ -137,10 +137,6 @@ private void genABQP(MapGroup1 map1, byte[] pkSeed)
         if (params.isPkExpandShake())
         {
             snovaShake(pkSeed, prngOutput.length, prngOutput);
-            // SHAKE-based expansion
-//            SHAKEDigest shake = new SHAKEDigest(128);
-//            shake.update(pkSeed, 0, pkSeed.length);
-//            shake.doFinal(prngOutput, 0, prngOutput.length);
         }
         else
         {