Skip to content

Commit 7d95b08

Browse files
author
gefeili
committed
Try to fix the bug of null pointer
1 parent 5badfff commit 7d95b08

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

pg/src/main/java/org/bouncycastle/openpgp/PGPEncryptedDataGenerator.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -265,11 +265,11 @@ private OutputStream open(
265265
// data is encrypted by AEAD Encrypted Data packet (rfc4880bis10), so write v5 SKESK packet
266266
if (isV5StyleAEAD)
267267
{
268-
writeOpenPGPv5ESKPacket(method, sessionInfo);
268+
writeOpenPGPv5ESKPacket(method, sessionKey);
269269
}
270270
else // data is encrypted by v2 SEIPD (AEAD), so write v6 SKESK packet
271271
{
272-
writeOpenPGPv6ESKPacket(method, aeadDataEncryptor.getAEADAlgorithm(), sessionInfo);
272+
writeOpenPGPv6ESKPacket(method, aeadDataEncryptor.getAEADAlgorithm(), sessionKey);
273273
}
274274
}
275275
// OpenPGP v4

pg/src/main/java/org/bouncycastle/openpgp/operator/PBEKeyEncryptionMethodGenerator.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ public ContainedPacket generateV6(int kekAlgorithm, int aeadAlgorithm, byte[] se
179179

180180
// If we use this method, roundtripping v5 AEAD is broken.
181181
// TODO: Investigate
182-
private ContainedPacket generateV5ESK(int kekAlgorithm, int aeadAlgorithm, byte[] sessionInfo)
182+
private ContainedPacket generateV5ESK(int kekAlgorithm, int aeadAlgorithm, byte[] sessionKey)
183183
throws PGPException
184184
{
185185
byte[] ikm = getKey(kekAlgorithm);
@@ -194,15 +194,14 @@ private ContainedPacket generateV5ESK(int kekAlgorithm, int aeadAlgorithm, byte[
194194
random.nextBytes(iv);
195195

196196
int tagLen = AEADUtils.getAuthTagLength(aeadAlgorithm);
197-
byte[] sessionKey = getSessionKey(sessionInfo);
198197
byte[] eskAndTag = getEskAndTag(kekAlgorithm, aeadAlgorithm, sessionKey, ikm, iv, info);
199198
byte[] esk = Arrays.copyOfRange(eskAndTag, 0, eskAndTag.length - tagLen);
200199
byte[] tag = Arrays.copyOfRange(eskAndTag, esk.length, eskAndTag.length);
201200

202201
return SymmetricKeyEncSessionPacket.createV5Packet(kekAlgorithm, aeadAlgorithm, iv, s2k, esk, tag);
203202
}
204203

205-
private ContainedPacket generateV6ESK(int kekAlgorithm, int aeadAlgorithm, byte[] sessionInfo)
204+
private ContainedPacket generateV6ESK(int kekAlgorithm, int aeadAlgorithm, byte[] sessionKey)
206205
throws PGPException
207206
{
208207
byte[] ikm = getKey(kekAlgorithm);
@@ -218,7 +217,6 @@ private ContainedPacket generateV6ESK(int kekAlgorithm, int aeadAlgorithm, byte[
218217
random.nextBytes(iv);
219218

220219
int tagLen = AEADUtils.getAuthTagLength(aeadAlgorithm);
221-
byte[] sessionKey = getSessionKey(sessionInfo);
222220
byte[] eskAndTag = getEskAndTag(kekAlgorithm, aeadAlgorithm, sessionKey, kek, iv, info);
223221
byte[] esk = Arrays.copyOfRange(eskAndTag, 0, eskAndTag.length - tagLen);
224222
byte[] tag = Arrays.copyOfRange(eskAndTag, esk.length, eskAndTag.length);

0 commit comments

Comments
 (0)