Skip to content

Commit 8b3fdd3

Browse files
author
gefeili
committed
Roll back changes in PGPAeadTest
1 parent f959bc9 commit 8b3fdd3

File tree

1 file changed

+8
-30
lines changed

1 file changed

+8
-30
lines changed

pg/src/test/java/org/bouncycastle/openpgp/test/PGPAeadTest.java

Lines changed: 8 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@
4444
import org.bouncycastle.openpgp.operator.jcajce.JcePBEDataDecryptorFactoryBuilder;
4545
import org.bouncycastle.openpgp.operator.jcajce.JcePBEKeyEncryptionMethodGenerator;
4646
import org.bouncycastle.openpgp.operator.jcajce.JcePGPDataEncryptorBuilder;
47-
import org.bouncycastle.test.DumpUtil;
4847
import org.bouncycastle.util.Arrays;
4948
import org.bouncycastle.util.Exceptions;
5049
import org.bouncycastle.util.Strings;
@@ -196,53 +195,32 @@ private void knownV6TestVectorDecryptionTests()
196195
private void testBcRoundTrip(boolean v5AEAD, int aeadAlg, int symAlg, byte[] plaintext, char[] password)
197196
throws PGPException, IOException
198197
{
199-
String armored = testBcEncryption(v5AEAD, aeadAlg, symAlg, plaintext, password, true);
198+
String armored = testBcEncryption(v5AEAD, aeadAlg, symAlg, plaintext, password);
200199
testBcDecryption(armored, password, plaintext);
201-
if (!v5AEAD)
202-
{
203-
armored = testBcEncryption(v5AEAD, aeadAlg, symAlg, plaintext, password, false);
204-
testBcDecryption(armored, password, plaintext);
205-
}
206-
207200
}
208201

209202
private void testJceRoundTrip(boolean v5AEAD, int aeadAlg, int symAlg, byte[] plaintext, char[] password)
210203
throws PGPException, IOException
211204
{
212-
String armored = testJceEncryption(v5AEAD, aeadAlg, symAlg, plaintext, password, true);
205+
String armored = testJceEncryption(v5AEAD, aeadAlg, symAlg, plaintext, password);
213206
testJceDecryption(armored, password, plaintext);
214-
if (!v5AEAD)
215-
{
216-
armored = testJceEncryption(v5AEAD, aeadAlg, symAlg, plaintext, password, false);
217-
testJceDecryption(armored, password, plaintext);
218-
}
219207
}
220208

221209
private void testBcJceRoundTrip(boolean v5AEAD, int aeadAlg, int symAlg, byte[] plaintext, char[] password)
222210
throws PGPException, IOException
223211
{
224-
String armored = testBcEncryption(v5AEAD, aeadAlg, symAlg, plaintext, password, true);
212+
String armored = testBcEncryption(v5AEAD, aeadAlg, symAlg, plaintext, password);
225213
testJceDecryption(armored, password, plaintext);
226-
if (!v5AEAD)
227-
{
228-
armored = testBcEncryption(v5AEAD, aeadAlg, symAlg, plaintext, password, false);
229-
testJceDecryption(armored, password, plaintext);
230-
}
231214
}
232215

233216
private void testJceBcRoundTrip(boolean v5AEAD, int aeadAlg, int symAlg, byte[] plaintext, char[] password)
234217
throws PGPException, IOException
235218
{
236-
String armored = testJceEncryption(v5AEAD, aeadAlg, symAlg, plaintext, password, true);
219+
String armored = testJceEncryption(v5AEAD, aeadAlg, symAlg, plaintext, password);
237220
testBcDecryption(armored, password, plaintext);
238-
if (!v5AEAD)
239-
{
240-
armored = testJceEncryption(v5AEAD, aeadAlg, symAlg, plaintext, password, false);
241-
testBcDecryption(armored, password, plaintext);
242-
}
243221
}
244222

245-
private String testBcEncryption(boolean v5AEAD, int aeadAlg, int symAlg, byte[] plaintext, char[] password, boolean setForceSessionKey)
223+
private String testBcEncryption(boolean v5AEAD, int aeadAlg, int symAlg, byte[] plaintext, char[] password)
246224
throws PGPException, IOException
247225
{
248226
ByteArrayOutputStream ciphertextOut = new ByteArrayOutputStream();
@@ -259,7 +237,7 @@ private String testBcEncryption(boolean v5AEAD, int aeadAlg, int symAlg, byte[]
259237
encBuilder.setWithAEAD(aeadAlg, 6);
260238

261239
PGPEncryptedDataGenerator encGen = new PGPEncryptedDataGenerator(encBuilder, false);
262-
encGen.setForceSessionKey(setForceSessionKey);
240+
encGen.setForceSessionKey(true);
263241
PBEKeyEncryptionMethodGenerator encMethodGen = new BcPBEKeyEncryptionMethodGenerator(password,
264242
digestCalculatorProvider.get(HashAlgorithmTags.SHA256));
265243
encGen.addMethod(encMethodGen);
@@ -287,7 +265,7 @@ private String testBcEncryption(boolean v5AEAD, int aeadAlg, int symAlg, byte[]
287265
return armored;
288266
}
289267

290-
private String testJceEncryption(boolean v5AEAD, int aeadAlg, int symAlg, byte[] plaintext, char[] password, boolean setForceSessionKey)
268+
private String testJceEncryption(boolean v5AEAD, int aeadAlg, int symAlg, byte[] plaintext, char[] password)
291269
throws PGPException, IOException
292270
{
293271
BouncyCastleProvider provider = new BouncyCastleProvider();
@@ -306,7 +284,7 @@ private String testJceEncryption(boolean v5AEAD, int aeadAlg, int symAlg, byte[]
306284
}
307285
encBuilder.setWithAEAD(aeadAlg, 6);
308286
PGPEncryptedDataGenerator encGen = new PGPEncryptedDataGenerator(encBuilder, false);
309-
encGen.setForceSessionKey(setForceSessionKey);
287+
encGen.setForceSessionKey(true);
310288
PBEKeyEncryptionMethodGenerator encMethodGen = new JcePBEKeyEncryptionMethodGenerator(password,
311289
digestCalculatorProvider.get(HashAlgorithmTags.SHA256));
312290
encGen.addMethod(encMethodGen);

0 commit comments

Comments
 (0)