Fix the issue in OpenPGPSignature

gefeili · gefeili · commit 8d2d9d4941c7 · 2025-05-25T21:07:40.000+09:30
diff --git a/pg/src/main/java/org/bouncycastle/openpgp/api/OpenPGPSignature.java b/pg/src/main/java/org/bouncycastle/openpgp/api/OpenPGPSignature.java
@@ -299,9 +299,10 @@ void sanitize(OpenPGPCertificate.OpenPGPComponentKey issuer,
                     this, "Signature predates issuer key creation time.");
         }
 
-        for (Iterator it = hashed.getNotationDataOccurrences().iterator(); it.hasNext(); )
+        NotationData[] notations = hashed.getNotationDataOccurrences();
+        for (int i = 0; i< notations.length; i++ )
         {
-            NotationData notation = (NotationData)it.next();
+            NotationData notation = notations[i];
             if (notation.isCritical())
             {
                 throw new MalformedOpenPGPSignatureException(

Original file line number	Diff line number	Diff line change
`@@ -299,9 +299,10 @@ void sanitize(OpenPGPCertificate.OpenPGPComponentKey issuer,`
`299`	`299`	`this, "Signature predates issuer key creation time.");`
`300`	`300`	`}`
`301`	`301`
`302`		`- for (Iterator it = hashed.getNotationDataOccurrences().iterator(); it.hasNext(); )`
	`302`	`+ NotationData[] notations = hashed.getNotationDataOccurrences();`
	`303`	`+ for (int i = 0; i< notations.length; i++ )`
`303`	`304`	`{`
`304`		`- NotationData notation = (NotationData)it.next();`
	`305`	`+ NotationData notation = notations[i];`
`305`	`306`	`if (notation.isCritical())`
`306`	`307`	`{`
`307`	`308`	`throw new MalformedOpenPGPSignatureException(`