removed unnecessary public "internal" method.

Author: dghgit

core/src/main/java/org/bouncycastle/pqc/crypto/mlkem/MLKEMKeyPairGenerator.java

@@ -44,14 +44,4 @@ public AsymmetricCipherKeyPair generateKeyPair()
     {
         return genKeyPair();
     }
-
-    public AsymmetricCipherKeyPair internalGenerateKeyPair(byte[] d, byte[] z)
-    {
-        byte[][] keyPair = mlkemParams.getEngine().generateKemKeyPairInternal(d, z);
-
-        MLKEMPublicKeyParameters pubKey = new MLKEMPublicKeyParameters(mlkemParams, keyPair[0], keyPair[1]);
-        MLKEMPrivateKeyParameters privKey = new MLKEMPrivateKeyParameters(mlkemParams,  keyPair[2], keyPair[3], keyPair[4], keyPair[0], keyPair[1], keyPair[5]);
-
-        return new AsymmetricCipherKeyPair(pubKey, privKey);
-    }
 }

core/src/test/java/org/bouncycastle/pqc/crypto/test/MLKEMTest.java

@@ -29,6 +29,7 @@
 import org.bouncycastle.test.TestResourceFinder;
 import org.bouncycastle.util.Arrays;
 import org.bouncycastle.util.encoders.Hex;
+import org.bouncycastle.util.test.FixedSecureRandom;
 
 public class MLKEMTest
     extends TestCase
@@ -84,13 +85,13 @@ public void testKeyGen() throws IOException
                         MLKEMParameters parameters = params[fileIndex];
 
                         MLKEMKeyPairGenerator kpGen = new MLKEMKeyPairGenerator();
-                        MLKEMKeyGenerationParameters genParam = new MLKEMKeyGenerationParameters(new SecureRandom(), parameters);
+                        MLKEMKeyGenerationParameters genParam = new MLKEMKeyGenerationParameters(new FixedSecureRandom(Arrays.concatenate(d, z)), parameters);
 
                         //
                         // Generate keys and test.
                         //
                         kpGen.init(genParam);
-                        AsymmetricCipherKeyPair kp = kpGen.internalGenerateKeyPair(d, z);
+                        AsymmetricCipherKeyPair kp = kpGen.generateKeyPair();
 
                         MLKEMPublicKeyParameters pubParams = (MLKEMPublicKeyParameters)PublicKeyFactory.createKey(
                             SubjectPublicKeyInfoFactory.createSubjectPublicKeyInfo((MLKEMPublicKeyParameters)kp.getPublic()));
@@ -142,13 +143,13 @@ public void testKeyGenCombinedVectorSet() throws IOException
                     MLKEMParameters parameters = (MLKEMParameters)parametersMap.get((String)buf.get("parameterSet"));
 
                     MLKEMKeyPairGenerator kpGen = new MLKEMKeyPairGenerator();
-                    MLKEMKeyGenerationParameters genParam = new MLKEMKeyGenerationParameters(new SecureRandom(), parameters);
+                    MLKEMKeyGenerationParameters genParam = new MLKEMKeyGenerationParameters(new FixedSecureRandom(Arrays.concatenate(d, z)), parameters);
 
                     //
                     // Generate keys and test.
                     //
                     kpGen.init(genParam);
-                    AsymmetricCipherKeyPair kp = kpGen.internalGenerateKeyPair(d, z);
+                    AsymmetricCipherKeyPair kp = kpGen.generateKeyPair();
 
                     MLKEMPublicKeyParameters pubParams = (MLKEMPublicKeyParameters)PublicKeyFactory.createKey(
                         SubjectPublicKeyInfoFactory.createSubjectPublicKeyInfo((MLKEMPublicKeyParameters)kp.getPublic()));
@@ -458,9 +459,9 @@ public void testMLKEM()
         SecureRandom random = new SecureRandom();
         MLKEMKeyPairGenerator keyGen = new MLKEMKeyPairGenerator();
 
-        keyGen.init(new MLKEMKeyGenerationParameters(random, MLKEMParameters.ml_kem_1024));
+        keyGen.init(new MLKEMKeyGenerationParameters(new FixedSecureRandom(Arrays.concatenate(d, z)), MLKEMParameters.ml_kem_1024));
 
-        AsymmetricCipherKeyPair keyPair = keyGen.internalGenerateKeyPair(d, z);
+        AsymmetricCipherKeyPair keyPair = keyGen.generateKeyPair();
         assertTrue(Arrays.areEqual(Hex.decode(expectedPubKey), ((MLKEMPublicKeyParameters)keyPair.getPublic()).getEncoded()));
 
         assertTrue(Arrays.areEqual(Hex.decode(expectedPrivKey), ((MLKEMPrivateKeyParameters)keyPair.getPrivate()).getEncoded()));