Added system property to ignore with faulty extension bytes in OIDs. Relates to github #1758

Author: dghgit

core/src/main/java/org/bouncycastle/asn1/ASN1RelativeOID.java

@@ -7,6 +7,7 @@
 import java.util.concurrent.ConcurrentMap;
 
 import org.bouncycastle.util.Arrays;
+import org.bouncycastle.util.Properties;
 
 public class ASN1RelativeOID
     extends ASN1Primitive
@@ -254,7 +255,12 @@ static boolean isValidContents(byte[] contents)
         for (int i = 0; i < contents.length; ++i)
         {
             if (subIDStart && (contents[i] & 0xff) == 0x80)
-                return false;
+            {
+                if (!Properties.isOverrideSet("org.bouncycastle.asn1.allow_wrong_oid_enc"))
+                {
+                    return false;
+                }
+            }
 
             subIDStart = (contents[i] & 0x80) == 0;
         }

core/src/test/java/org/bouncycastle/asn1/test/ObjectIdentifierTest.java

@@ -1,6 +1,7 @@
 package org.bouncycastle.asn1.test;
 
 import org.bouncycastle.asn1.ASN1ObjectIdentifier;
+import org.bouncycastle.util.encoders.Hex;
 import org.bouncycastle.util.test.SimpleTest;
 import org.bouncycastle.util.test.TestResult;
 
@@ -24,7 +25,24 @@ public void performTest()
         {
             isEquals("invalid OID contents", e.getMessage());
         }
-        
+
+        byte[] faultyOID = Hex.decode("06092A864886FC6B048000");
+        try
+        {
+            ASN1ObjectIdentifier.getInstance(faultyOID);
+            fail("no exception");
+        }
+        catch (Exception e)
+        {
+            isEquals("failed to construct object identifier from byte[]: invalid OID contents", e.getMessage());
+        }
+
+        System.setProperty("org.bouncycastle.asn1.allow_wrong_oid_enc", "true");
+        String oid = ASN1ObjectIdentifier.getInstance(faultyOID).getId();
+
+        System.clearProperty("org.bouncycastle.asn1.allow_wrong_oid_enc");
+        isEquals("1.2.840.114283.4.0", oid);
+
         // exercise the object cache
         for (int i = 0; i < 100; i++)
         {