Minor changes in GF16.encode

gefeili · gefeili · commit bfa82f1efb5b · 2025-04-04T11:06:00.000+10:30
diff --git a/core/src/main/java/org/bouncycastle/util/GF16.java b/core/src/main/java/org/bouncycastle/util/GF16.java
@@ -134,9 +134,9 @@ public static void decode(byte[] input, int inOff, byte[] output, int outOff, in
      */
     public static void encode(byte[] input, byte[] output, int inputLen)
     {
-        int i, inOff = 0;
+        int i, inOff = 0, blocks = inputLen >> 1;
         // Process pairs of 4-bit values
-        for (i = 0; i < inputLen / 2; i++)
+        for (i = 0; i < blocks; i++)
         {
             int lowerNibble = input[inOff++] & 0x0F;
             int upperNibble = (input[inOff++] & 0x0F) << 4;
@@ -151,9 +151,9 @@ public static void encode(byte[] input, byte[] output, int inputLen)
 
     public static void encode(byte[] input, byte[] output, int outOff, int inputLen)
     {
-        int i, inOff = 0;
+        int i, inOff = 0, blocks = inputLen >> 1;
         // Process pairs of 4-bit values
-        for (i = 0; i < inputLen / 2; i++)
+        for (i = 0; i < blocks; i++)
         {
             int lowerNibble = input[inOff++] & 0x0F;
             int upperNibble = (input[inOff++] & 0x0F) << 4;

Original file line number	Diff line number	Diff line change
`@@ -134,9 +134,9 @@ public static void decode(byte[] input, int inOff, byte[] output, int outOff, in`
`134`	`134`	`*/`
`135`	`135`	`public static void encode(byte[] input, byte[] output, int inputLen)`
`136`	`136`	`{`
`137`		`- int i, inOff = 0;`
	`137`	`+ int i, inOff = 0, blocks = inputLen >> 1;`
`138`	`138`	`// Process pairs of 4-bit values`
`139`		`- for (i = 0; i < inputLen / 2; i++)`
	`139`	`+ for (i = 0; i < blocks; i++)`
`140`	`140`	`{`
`141`	`141`	`int lowerNibble = input[inOff++] & 0x0F;`
`142`	`142`	`int upperNibble = (input[inOff++] & 0x0F) << 4;`
`@@ -151,9 +151,9 @@ public static void encode(byte[] input, byte[] output, int inputLen)`
`151`	`151`
`152`	`152`	`public static void encode(byte[] input, byte[] output, int outOff, int inputLen)`
`153`	`153`	`{`
`154`		`- int i, inOff = 0;`
	`154`	`+ int i, inOff = 0, blocks = inputLen >> 1;`
`155`	`155`	`// Process pairs of 4-bit values`
`156`		`- for (i = 0; i < inputLen / 2; i++)`
	`156`	`+ for (i = 0; i < blocks; i++)`
`157`	`157`	`{`
`158`	`158`	`int lowerNibble = input[inOff++] & 0x0F;`
`159`	`159`	`int upperNibble = (input[inOff++] & 0x0F) << 4;`