Skip to content

Commit cefbc72

Browse files
committed
Fix PGPGeneralTest to use proper method of setting/getting AEAD algorithm preferences
1 parent 4e9b35a commit cefbc72

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

pg/src/test/java/org/bouncycastle/openpgp/test/PGPGeneralTest.java

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
import org.bouncycastle.bcpg.sig.KeyFlags;
3636
import org.bouncycastle.bcpg.sig.NotationData;
3737
import org.bouncycastle.bcpg.sig.PolicyURI;
38+
import org.bouncycastle.bcpg.sig.PreferredAEADCiphersuites;
3839
import org.bouncycastle.bcpg.sig.RegularExpression;
3940
import org.bouncycastle.bcpg.sig.RevocationKey;
4041
import org.bouncycastle.bcpg.sig.RevocationKeyTags;
@@ -104,7 +105,7 @@
104105
import org.bouncycastle.openpgp.operator.jcajce.JcePBESecretKeyDecryptorBuilder;
105106
import org.bouncycastle.openpgp.operator.jcajce.JcePBESecretKeyEncryptorBuilder;
106107
import org.bouncycastle.openpgp.operator.jcajce.JcePublicKeyDataDecryptorFactoryBuilder;
107-
import org.bouncycastle.util.Arrays;
108+
import org.bouncycastle.util.Objects;
108109
import org.bouncycastle.util.Strings;
109110
import org.bouncycastle.util.encoders.Base64;
110111
import org.bouncycastle.util.test.SimpleTest;
@@ -1927,9 +1928,12 @@ private void sigsubpacketTest()
19271928

19281929
PGPSignatureSubpacketGenerator svg = new PGPSignatureSubpacketGenerator();
19291930

1930-
int[] aeadAlgs = new int[]{AEADAlgorithmTags.EAX,
1931-
AEADAlgorithmTags.OCB, AEADAlgorithmTags.GCM, AEADAlgorithmTags.GCM};
1932-
svg.setPreferredAEADAlgorithms(true, aeadAlgs);
1931+
PreferredAEADCiphersuites.Builder builder = PreferredAEADCiphersuites.builder(true);
1932+
builder.addCombination(SymmetricKeyAlgorithmTags.AES_256, AEADAlgorithmTags.EAX)
1933+
.addCombination(SymmetricKeyAlgorithmTags.AES_256, AEADAlgorithmTags.OCB)
1934+
.addCombination(SymmetricKeyAlgorithmTags.AES_256, AEADAlgorithmTags.GCM)
1935+
.addCombination(SymmetricKeyAlgorithmTags.AES_128, AEADAlgorithmTags.GCM);
1936+
svg.setPreferredAEADCiphersuites(builder);
19331937
svg.setFeature(true, Features.FEATURE_MODIFICATION_DETECTION);
19341938
svg.setKeyFlags(true, KeyFlags.CERTIFY_OTHER + KeyFlags.SIGN_DATA);
19351939
PGPSignatureSubpacketVector hashedPcks = svg.generate();
@@ -1961,7 +1965,7 @@ sgnKeyPair, identity, new BcPGPDigestCalculatorProvider().get(HashAlgorithmTags.
19611965
{
19621966
PGPSignature sig = (PGPSignature)sit.next();
19631967
PGPSignatureSubpacketVector v = sig.getHashedSubPackets();
1964-
if (!Arrays.areEqual(v.getPreferredAEADAlgorithms(), aeadAlgs))
1968+
if (!Objects.areEqual(v.getPreferredAEADCiphersuites(), builder.build()))
19651969
{
19661970
fail("preferred aead algs don't match");
19671971
}

0 commit comments

Comments
 (0)