Clarify tagging of certIssuer field (CHOICE type)

Author: peterdettman

core/src/main/java/org/bouncycastle/asn1/bc/LinkedCertificate.java

@@ -59,7 +59,7 @@ private LinkedCertificate(ASN1Sequence seq)
                 switch (tagged.getTagNo())
                 {
                 case 0:
-                    certIssuer = X500Name.getInstance(tagged, false);
+                    certIssuer = X500Name.getInstance(tagged, true); // CHOICE
                     break;
                 case 1:
                     cACerts = GeneralNames.getInstance(tagged, false);
@@ -114,7 +114,7 @@ public ASN1Primitive toASN1Primitive()
 
         if (certIssuer != null)
         {
-            v.add(new DERTaggedObject(false, 0, certIssuer));
+            v.add(new DERTaggedObject(true, 0, certIssuer)); // CHOICE
         }
         if (cACerts != null)
         {

core/src/test/java/org/bouncycastle/asn1/test/LinkedCertificateTest.java

@@ -70,11 +70,7 @@ private void checkConstruction(
 
         checkValues(linked, digestInfo, certLocation, certIssuer, caCerts);
 
-        ASN1InputStream aIn = new ASN1InputStream(linked.toASN1Primitive().getEncoded());
-
-        ASN1Sequence seq = (ASN1Sequence)aIn.readObject();
-
-        linked = LinkedCertificate.getInstance(seq);
+        linked = LinkedCertificate.getInstance(linked.getEncoded());
 
         checkValues(linked, digestInfo, certLocation, certIssuer, caCerts);
     }