Clarify dependency b/w getSessionToResume and getCipherSuites

Author: peterdettman

tls/src/main/java/org/bouncycastle/tls/DTLSClientProtocol.java

@@ -420,10 +420,11 @@ protected byte[] generateClientHello(ClientHandshakeState state)
 
         TlsSession sessionToResume = offeringDTLSv12Minus ? client.getSessionToResume() : null;
 
-        boolean fallback = client.isFallback();
-
+        // NOTE: Client is free to modify the cipher suites up until getSessionToResume
         state.offeredCipherSuites = client.getCipherSuites();
 
+        boolean fallback = client.isFallback();
+
         state.clientExtensions = TlsExtensionsUtils.ensureExtensionsInitialised(client.getClientExtensions());
 
         final boolean shouldUseEMS = client.shouldUseExtendedMasterSecret();

tls/src/main/java/org/bouncycastle/tls/TlsClientProtocol.java

@@ -1808,10 +1808,11 @@ protected void sendClientHello()
 
         TlsSession sessionToResume = offeringTLSv12Minus ? tlsClient.getSessionToResume() : null;
 
-        boolean fallback = tlsClient.isFallback();
-
+        // NOTE: Client is free to modify the cipher suites up until getSessionToResume
         int[] offeredCipherSuites = tlsClient.getCipherSuites();
 
+        boolean fallback = tlsClient.isFallback();
+
         this.clientExtensions = TlsExtensionsUtils.ensureExtensionsInitialised(tlsClient.getClientExtensions());
 
         final boolean shouldUseEMS = tlsClient.shouldUseExtendedMasterSecret();