Merge branch 'mt-johan-feature/pbmac1-prf'

Author: dghgit

pkix/src/main/java/org/bouncycastle/pkcs/jcajce/JcePBMac1CalculatorBuilder.java

@@ -187,6 +187,7 @@ public MacCalculator build(final char[] password)
                 salt = pbeParams.getSalt();
                 iterationCount = BigIntegers.intValueExact(pbeParams.getIterationCount());
                 keySize = BigIntegers.intValueExact(pbeParams.getKeyLength()) * 8;
+                prf = pbeParams.getPrf();
             }
 
             SecretKeyFactory secFact = helper.createSecretKeyFactory("PBKDF2");

pkix/src/test/java/org/bouncycastle/pkcs/test/PBETest.java

@@ -3,9 +3,17 @@
 import java.security.Security;
 
 import junit.framework.TestCase;
+
+import org.bouncycastle.asn1.nist.NISTObjectIdentifiers;
+import org.bouncycastle.asn1.pkcs.PBKDF2Params;
+import org.bouncycastle.asn1.pkcs.PBMAC1Params;
+import org.bouncycastle.asn1.pkcs.PKCSObjectIdentifiers;
+import org.bouncycastle.asn1.x509.AlgorithmIdentifier;
 import org.bouncycastle.jce.provider.BouncyCastleProvider;
 import org.bouncycastle.operator.MacCalculator;
+import org.bouncycastle.operator.OperatorCreationException;
 import org.bouncycastle.pkcs.jcajce.JcePBMac1CalculatorBuilder;
+import org.bouncycastle.pkcs.jcajce.JcePBMac1CalculatorProviderBuilder;
 import org.bouncycastle.util.Strings;
 import org.bouncycastle.util.encoders.Hex;
 
@@ -29,4 +37,21 @@ public void testPBESHA256()
         assertEquals("55ac046e56e3089fec1691c22544b605f94185216dde0465e68b9d57c20dacbc", Hex.toHexString((byte[])pbCalculator.getKey().getRepresentation()));
 
     }
+
+    void testPbmac1PrfPropagation() throws OperatorCreationException {
+        AlgorithmIdentifier prf = new AlgorithmIdentifier(NISTObjectIdentifiers.id_hmacWithSHA3_512, null);;
+        AlgorithmIdentifier protectionAlgorithm = new AlgorithmIdentifier(PKCSObjectIdentifiers.id_PBMAC1,
+            new PBMAC1Params(
+                new AlgorithmIdentifier(PKCSObjectIdentifiers.id_PBKDF2, new PBKDF2Params("salt".getBytes(), 1234, 64, prf)),
+                new AlgorithmIdentifier(NISTObjectIdentifiers.id_hmacWithSHA3_512, null)
+            )
+        );
+        MacCalculator calculator = new JcePBMac1CalculatorProviderBuilder()
+                .setProvider(new BouncyCastleProvider()).build().get(protectionAlgorithm, "foobar123".toCharArray());
+        AlgorithmIdentifier actualPrf = PBKDF2Params.getInstance(
+            PBMAC1Params.getInstance(calculator.getKey().getAlgorithmIdentifier().getParameters()).getKeyDerivationFunc().getParameters()
+        ).getPrf();
+        System.out.println("Should be true: " + prf.equals(actualPrf));
+    }
+
 }