fixing code smell issues, globalThis and negatation

Author: SoLetsDev

src/ECER.Clients.RegistryPortal/ecer.clients.registryportal.client/src/components/CertificationCard.vue

@@ -172,13 +172,13 @@ export default defineComponent({
         }
       } else if (this.certification.certificatePDFGeneration === "Yes") {
         const file = await getCertificateFileById(this.certification.id ?? "");
-        this.pdfUrl = window.URL.createObjectURL(file.data);
+        this.pdfUrl = globalThis.URL.createObjectURL(file.data);
         this.fileSize = humanFileSize(file.data.size);
       }
     }
   },
   unmounted() {
-    window.URL.revokeObjectURL(this.pdfUrl);
+    globalThis.URL.revokeObjectURL(this.pdfUrl);
   },
   methods: {
     generateFileDisplayName() {

src/ECER.Clients.RegistryPortal/ecer.clients.registryportal.client/src/components/DownloadFileLink.vue

@@ -25,15 +25,15 @@ export default defineComponent({
     };
   },
   unmounted() {
-    window.URL.revokeObjectURL(this.documentUrl);
+    globalThis.URL.revokeObjectURL(this.documentUrl);
   },
   methods: {
     async downloadFile() {
       this.loading = true;
 
       try {
         const response = await this.getFileFunction();
-        this.documentUrl = window.URL.createObjectURL(response.data);
+        this.documentUrl = globalThis.URL.createObjectURL(response.data);
 
         const anchor = document.createElement("a");
         anchor.href = this.documentUrl;

src/ECER.Clients.RegistryPortal/ecer.clients.registryportal.client/src/components/LookupCertification.vue

@@ -184,7 +184,7 @@ export default defineComponent({
 
           //reset grecaptcha after success, token cannot be reused
           this.recaptchaToken = "";
-          window.grecaptcha.reset();
+          globalThis.grecaptcha.reset();
           await this.$nextTick();
           (this.$refs.lookupForm as VForm).resetValidation();
         }

src/ECER.Clients.RegistryPortal/ecer.clients.registryportal.client/src/components/MessageList.vue

@@ -63,7 +63,7 @@ export default defineComponent({
       this.messages = response.data?.communications || [];
       this.messageCount = response.data?.totalMessagesCount || 0;
 
-      window.scrollTo({ top: 0, behavior: "smooth" });
+      globalThis.scrollTo({ top: 0, behavior: "smooth" });
 
       // After the list is rendered, select/load the first message if available
       await nextTick();

src/ECER.Clients.RegistryPortal/ecer.clients.registryportal.client/src/components/MessageListItem.vue

@@ -58,7 +58,7 @@ export default defineComponent({
     async loadChildMessages(messageId: string) {
       this.messageStore.currentThread = (await getChildMessages({ parentId: messageId })).data?.communications;
       this.messageStore.currentMessage = this.message;
-      window.scrollTo({
+      globalThis.scrollTo({
         top: 0,
         behavior: "smooth",
       });

src/ECER.Clients.RegistryPortal/ecer.clients.registryportal.client/src/components/Snackbar.vue

@@ -114,7 +114,7 @@ export default {
       }
     },
     timeoutCounter() {
-      this.polling = window.setInterval(() => {
+      this.polling = globalThis.setInterval(() => {
         if (this.pause) {
           this.timeout += 1;
         }

src/ECER.Clients.RegistryPortal/ecer.clients.registryportal.client/src/components/UpsertCharacterReference.vue

@@ -125,7 +125,7 @@ export default defineComponent({
         if (refSet.has(`${this.formStore.formData.firstName.toLowerCase()} ${this.formStore.formData.lastName.toLowerCase()}`)) {
           this.isDuplicateReference = true;
           //scroll to top of page
-          window.scrollTo({
+          globalThis.scrollTo({
             top: 0,
             behavior: "smooth",
           });

src/ECER.Clients.RegistryPortal/ecer.clients.registryportal.client/src/components/UpsertWorkExperienceReference.vue

@@ -129,7 +129,7 @@ export default defineComponent({
         if (refSet.has(`${this.formStore.formData.firstName.toLowerCase()} ${this.formStore.formData.lastName.toLowerCase()}`)) {
           this.isDuplicateReference = true;
           //scroll to top of page
-          window.scrollTo({
+          globalThis.scrollTo({
             top: 0,
             behavior: "smooth",
           });

src/ECER.Clients.RegistryPortal/ecer.clients.registryportal.client/src/components/inputs/EceEducation.vue

@@ -573,7 +573,7 @@ export default defineComponent({
   watch: {
     mode(newValue) {
       if (newValue === "list") {
-        window.scrollTo({
+        globalThis.scrollTo({
           top: 0,
           behavior: "smooth",
         });

src/ECER.Clients.RegistryPortal/ecer.clients.registryportal.client/src/components/inputs/EceEmploymentExperience.vue

@@ -228,14 +228,14 @@ export default defineComponent({
       this.resetFormData();
       // Change mode to list
       this.mode = "list";
-      window.scroll(0, 0);
+      globalThis.scroll(0, 0);
     },
     handleAddInternationalCertification() {
       // Reset the form fields
       this.resetFormData();
       this.mode = "add";
       this.employmentExperienceFormMode = "add";
-      window.scroll(0, 0);
+      globalThis.scroll(0, 0);
     },
     handleEdit(reference: Components.Schemas.EmploymentReference) {
       // Set the form fields to component data
@@ -247,7 +247,7 @@ export default defineComponent({
 
       this.mode = "add";
       this.employmentExperienceFormMode = "edit";
-      window.scroll(0, 0);
+      globalThis.scroll(0, 0);
     },
     async handleDelete(_reference: Components.Schemas.EmploymentReference, index: number) {
       this.$emit("update:model-value", removeElementByIndex(this.modelValue, index));
@@ -288,7 +288,7 @@ export default defineComponent({
 
         this.mode = "list";
 
-        window.scroll(0, 0);
+        globalThis.scroll(0, 0);
       } else {
         this.alertStore.setFailureAlert("You must enter all required fields in the valid format.");
       }