ECER-4776: Sonar Qube ICRA eligibility object problems resolved

Author: farzadnadiri

src/ECER.Managers.Registry/ICRAEligibilityHandlers.cs

@@ -21,22 +21,11 @@ public class ICRAEligibilityHandlers(
   {
     ArgumentNullException.ThrowIfNull(request);
 
-    if (request.eligibility.Id == null)
-    {
-
-      var iCRAEligibilities = await iCRARepository.Query(new ICRAQuery
-      {
-        ByApplicantId = request.eligibility.ApplicantId,
-      }, cancellationToken);
-
-      var ICRAEligibilityResults = new ICRAEligibilitiesQueryResults(mapper.Map<IEnumerable<Contract.ICRA.ICRAEligibility>>(iCRAEligibilities)!);
-
-    }
-    var ICRAEligibilityId = await iCRARepository.Save(mapper.Map<Resources.Documents.ICRA.ICRAEligibility>(request.eligibility)!, cancellationToken);
+    var iCRAEligibilityId = await iCRARepository.Save(mapper.Map<Resources.Documents.ICRA.ICRAEligibility>(request.eligibility)!, cancellationToken);
 
     var freshIcraEligibilities = await iCRARepository.Query(new ICRAQuery
     {
-      ById = ICRAEligibilityId,
+      ById = iCRAEligibilityId,
     }, cancellationToken);
 
     return mapper.Map<Contract.ICRA.ICRAEligibility>(freshIcraEligibilities.SingleOrDefault())!;

src/ECER.Resources.Documents/ICRA/ICRARepository.cs

@@ -45,14 +45,14 @@ public async Task<IEnumerable<ICRAEligibility>> Query(ICRAQuery query, Cancellat
     return mapper.Map<IEnumerable<ICRAEligibility>>(results)!.ToList();
   }
 
-  public async Task<string> Save(ICRAEligibility eligibility, CancellationToken cancellationToken)
+  public async Task<string> Save(ICRAEligibility iCRAEligibility, CancellationToken cancellationToken)
   {
     await Task.CompletedTask;
 
-    var applicant = context.ContactSet.SingleOrDefault(c => c.ContactId == Guid.Parse(eligibility.ApplicantId));
-    if (applicant == null) throw new InvalidOperationException($"Applicant '{eligibility.ApplicantId}' not found");
+    var applicant = context.ContactSet.SingleOrDefault(c => c.ContactId == Guid.Parse(iCRAEligibility.ApplicantId));
+    if (applicant == null) throw new InvalidOperationException($"Applicant '{iCRAEligibility.ApplicantId}' not found");
 
-    var icraEligibility = mapper.Map<ecer_ICRAEligibilityAssessment>(eligibility)!;
+    var icraEligibility = mapper.Map<ecer_ICRAEligibilityAssessment>(iCRAEligibility)!;
     if (!icraEligibility.ecer_ICRAEligibilityAssessmentId.HasValue)
     {
       icraEligibility.ecer_ICRAEligibilityAssessmentId = Guid.NewGuid();