Skip to content

Commit 84dab6d

Browse files
committed
ECER-5116: PR feedbacks fixed
1 parent 08f704b commit 84dab6d

File tree

3 files changed

+17
-21
lines changed

3 files changed

+17
-21
lines changed

src/ECER.Clients.RegistryPortal/ecer.clients.registryportal.client/src/components/IcraCard.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212

1313
<div class="d-flex flex-row justify-start ga-3 flex-wrap ma-4">
1414
<v-card-actions>
15-
<router-link to="icra/eligibility">Learn more</router-link>
15+
<router-link :to="{ name: 'icra-eligibility' }">Learn more</router-link>
1616
</v-card-actions>
1717
</div>
1818
</v-card>

src/ECER.Clients.RegistryPortal/ecer.clients.registryportal.client/src/components/pages/Dashboard.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@
181181
Canadian-certified ECE.
182182
</p>
183183
<div class="mt-auto">
184-
<router-link class="mt-4" to="icra/eligibility">Learn more</router-link>
184+
<router-link class="mt-4" :to="{name: 'icra-eligibility'}">Learn more</router-link>
185185
</div>
186186
</Card>
187187
</v-col>

src/ECER.Clients.RegistryPortal/ecer.clients.registryportal.client/src/components/pages/IcraEligibility.vue

Lines changed: 15 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -16,34 +16,31 @@
1616
It does not apply to ECE Assistant of ECE One Year certification.
1717
</p>
1818
<ECEHeader title="The eligibility process" />
19-
<p class="mt-3">1. Submit your required documentation</p>
20-
<p class="mt-1">
21-
2. We will review your submission and determine if you are eligible to apply for ECE Five Year certification using professional experience you have
22-
outside of Canada
23-
</p>
24-
<p class="mt-1">
25-
3. If you are eligible, you may continue with your ECE Five Year application. If you are not eligible, we will contact you with other application
26-
options
27-
</p>
28-
19+
<ol class="ml-10 mt-3">
20+
<li>Submit your required documentation</li>
21+
<li>
22+
We will review your submission and determine if you are eligible to apply for ECE Five Year certification using professional experience you have
23+
outside of Canada
24+
</li>
25+
<li>
26+
If you are eligible, you may continue with your ECE Five Year application. If you are not eligible, we will contact you with other application options
27+
</li>
28+
</ol>
2929
<Callout class="mt-10" type="warning" title="Do you have 500 hours of work experience supervised by a Canadian-certified ECE?">
3030
If yes, you do not need to confirm your eligibility. Please
3131
<router-link class="mt-4" to="/">apply for certification directly here.</router-link>
3232
</Callout>
3333

3434
<h3 class="mt-13">When you are ready, you can begin your submission.</h3>
3535

36-
<v-btn class="mt-10" id="backToHome" size="large" color="primary" @click="handleBackToHome">
37-
<v-icon size="small" icon="mdi-arrow-left" class="mr-2"></v-icon>
38-
Back to home
39-
</v-btn>
36+
<v-btn class="mt-6" rounded="lg" color="primary" @click="router.push({ name: 'icra-eligibility-requirements' })">Check eligibility</v-btn>
4037
</div>
4138
</v-container>
4239
</template>
4340

4441
<script lang="ts">
4542
import { defineComponent } from "vue";
46-
import type { Components } from "@/types/openapi";
43+
import { useRouter } from "vue-router";
4744
import Breadcrumb from "@/components/Breadcrumb.vue";
4845
import ECEHeader from "@/components/ECEHeader.vue";
4946
import Callout from "../Callout.vue";
@@ -55,10 +52,9 @@ export default defineComponent({
5552
ECEHeader,
5653
Callout,
5754
},
58-
methods: {
59-
handleBackToHome() {
60-
this.$router.push("/");
61-
},
55+
setup() {
56+
const router = useRouter();
57+
return { router };
6258
},
6359
});
6460
</script>

0 commit comments

Comments
 (0)