Updated test

Author: pcatkins

src/ECER.Tests/Integration/RegistryApi/ApplicationTests.cs

@@ -316,44 +316,34 @@ await Host.Scenario(_ =>
   [Fact]
   public async Task SubmitApplication_TwiceBySameUser_ReturnsBadRequest()
   {
-    // Create and submit the first application
-    var firstApplication = CreateDraftApplication();
-    firstApplication.Id = Fixture.draftTestApplicationId2;
-
-    // Save first draft
-    await Host.Scenario(_ =>
-    {
-      _.WithExistingUser(Fixture.AuthenticatedBcscUserIdentity, Fixture.AuthenticatedBcscUser);
-      _.Put.Json(new SaveDraftApplicationRequest(firstApplication)).ToUrl($"/api/draftapplications/{firstApplication.Id}");
-      _.StatusCodeShouldBeOk();
-    });
-
-    // Submit first application
-    await Host.Scenario(_ =>
+    // Assert user already has submitted application
+    var applicationsResponse = await Host.Scenario(_ =>
     {
-      _.WithExistingUser(Fixture.AuthenticatedBcscUserIdentity, Fixture.AuthenticatedBcscUser);
-      _.Post.Json(new ApplicationSubmissionRequest(firstApplication.Id!)).ToUrl("/api/applications");
+      _.WithExistingUser(this.Fixture.AuthenticatedBcscUserIdentity, this.Fixture.AuthenticatedBcscUser);
+      _.Get.Url("/api/applications");
       _.StatusCodeShouldBeOk();
     });
+    var applications = await applicationsResponse.ReadAsJsonAsync<Application[]>();
+    applications.Where(application => application.Status == ApplicationStatus.Submitted).ShouldNotBeEmpty();
+    
+    // Create and submit application
+    var firstApplication = CreateDraftApplication();
+    firstApplication.Id = Fixture.draftTestApplicationId4;
+    firstApplication.CertificationTypes = new[] { CertificationType.EceAssistant };
 
-    // Create and attempt to submit a second application for the same user
-    var secondApplication = CreateDraftApplication();
-    secondApplication.Id = Fixture.draftTestApplicationId3;
-
-
-    // Save second draft
+    // Save draft
     await Host.Scenario(_ =>
     {
       _.WithExistingUser(Fixture.AuthenticatedBcscUserIdentity, Fixture.AuthenticatedBcscUser);
-      _.Put.Json(new SaveDraftApplicationRequest(secondApplication)).ToUrl($"/api/draftapplications/{secondApplication.Id}");
+      _.Put.Json(new SaveDraftApplicationRequest(firstApplication)).ToUrl($"/api/draftapplications/{firstApplication.Id}");
       _.StatusCodeShouldBeOk();
     });
 
-    // Attempt to submit second application — should fail
+    // Submit application
     await Host.Scenario(_ =>
     {
       _.WithExistingUser(Fixture.AuthenticatedBcscUserIdentity, Fixture.AuthenticatedBcscUser);
-      _.Post.Json(new ApplicationSubmissionRequest(secondApplication.Id!)).ToUrl("/api/applications");
+      _.Post.Json(new ApplicationSubmissionRequest(firstApplication.Id!)).ToUrl("/api/applications");
       _.StatusCodeShouldBe(HttpStatusCode.BadRequest);
     });
   }