Skip to content

Commit cc9375b

Browse files
authored
Merge pull request #1521 from bcgov/fix/rework5182
Fix/rework5182: Rework required
2 parents d096ef6 + 6cfa5f5 commit cc9375b

File tree

3 files changed

+13
-7
lines changed

3 files changed

+13
-7
lines changed

src/ECER.Clients.RegistryPortal/ecer.clients.registryportal.client/src/components/IcraEligibilityCard.vue

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
>
2727
<v-btn variant="flat" size="large" color="warning" @click="handleManageIcraEligibility">
2828
<v-icon size="large" icon="mdi-arrow-right" />
29-
Manage ICRA eligibility
29+
Manage Submission
3030
</v-btn>
3131
</v-card-actions>
3232
</div>
@@ -61,10 +61,11 @@ export default defineComponent({
6161
computed: {
6262
title(): string {
6363
switch (this.icraStore.icraEligibilityStatus) {
64-
case "Draft":
6564
case "Submitted":
6665
case "InReview":
6766
case "ReadyforReview":
67+
return "Your eligibility to apply with international certification is in review";
68+
case "Draft":
6869
case "Active":
6970
return "Your submission to determine eligibility to apply with international certification is in progress";
7071
default:

src/ECER.Clients.RegistryPortal/ecer.clients.registryportal.client/src/components/inputs/EceEmploymentExperience.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
</v-row>
2727
<v-row>
2828
<v-col md="8" lg="6" xl="4">
29-
<EceTextField id="txtWorkReferenceFirstName" v-model="firstName" label="first name" maxlength="100"></EceTextField>
29+
<EceTextField id="txtWorkReferenceFirstName" v-model="firstName" label="First name" maxlength="100"></EceTextField>
3030
</v-col>
3131
</v-row>
3232
<v-row>
@@ -35,7 +35,7 @@
3535
id="txtWorkReferenceEmail"
3636
v-model="emailAddress"
3737
:rules="[Rules.required(), Rules.email('Enter your reference\'s email in the format \'[email protected]\'')]"
38-
label="Reference email"
38+
label="Email"
3939
maxlength="200"
4040
></EceTextField>
4141
</v-col>

src/ECER.Clients.RegistryPortal/ecer.clients.registryportal.client/src/components/pages/Dashboard.vue

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -359,19 +359,24 @@ export default defineComponent({
359359
!this.certificationStore.hasCertifications &&
360360
!this.applicationStore.hasApplication &&
361361
!this.applicationStore.hasDraftApplication &&
362-
!this.icraStore.hasDraftIcraEligibility
362+
!this.icraStore.hasDraftIcraEligibility &&
363+
!this.icraStore.hasSubmittedIcraEligibility
363364
);
364365
},
365366
showIcraCard(): boolean {
366367
return (
367368
(this.configurationStore.applicationConfiguration.icraFeatureEnabled ?? false) &&
368369
!this.applicationStore.hasApplication &&
369370
!this.applicationStore.hasDraftApplication &&
370-
!this.icraStore.hasDraftIcraEligibility
371+
!this.icraStore.hasDraftIcraEligibility &&
372+
!this.icraStore.hasSubmittedIcraEligibility
371373
);
372374
},
373375
showIcraEligibilityCard(): boolean {
374-
return (this.configurationStore.applicationConfiguration.icraFeatureEnabled ?? false) && this.icraStore.hasDraftIcraEligibility;
376+
return (
377+
(this.configurationStore.applicationConfiguration.icraFeatureEnabled ?? false) &&
378+
(this.icraStore.hasDraftIcraEligibility || this.icraStore.hasSubmittedIcraEligibility)
379+
);
375380
},
376381
showLoading(): boolean {
377382
return (

0 commit comments

Comments
 (0)