Error handling cleanup

Author: pcatkins

src/ECER.Clients.PSPPortal/ECER.Clients.PSPPortal.Server/PspUser/ProfileEndpoints.cs

@@ -50,19 +50,33 @@ async Task<Results<Ok, BadRequest<PspRegistrationErrorResponse>>> (
             ),
             ctx.RequestAborted);
 
-          if (!result.IsSuccess && result.Error.HasValue)
+          if (!result.IsSuccess)
           {
-            return TypedResults.BadRequest(new PspRegistrationErrorResponse
+            var errorCode = PspRegistrationError.GenericError;
+
+            if (result.Error.HasValue)
             {
-              ErrorCode = result.Error.Value switch
+              errorCode = result.Error.Value switch
               {
-                RegisterPspUserError.PostSecondaryInstitutionNotFound => PspRegistrationError
-                  .PostSecondaryInstitutionNotFound,
-                RegisterPspUserError.PortalInvitationTokenInvalid => PspRegistrationError.PortalInvitationTokenInvalid,
-                RegisterPspUserError.PortalInvitationWrongStatus => PspRegistrationError.PortalInvitationWrongStatus,
-                RegisterPspUserError.BceidBusinessIdDoesNotMatch => PspRegistrationError.BceidBusinessIdDoesNotMatch,
-                _ => PspRegistrationError.PostSecondaryInstitutionNotFound
-              }
+                RegisterPspUserError.PostSecondaryInstitutionNotFound 
+                  => PspRegistrationError.PostSecondaryInstitutionNotFound,
+
+                RegisterPspUserError.PortalInvitationTokenInvalid 
+                  => PspRegistrationError.PortalInvitationTokenInvalid,
+
+                RegisterPspUserError.PortalInvitationWrongStatus 
+                  => PspRegistrationError.PortalInvitationWrongStatus,
+
+                RegisterPspUserError.BceidBusinessIdDoesNotMatch 
+                  => PspRegistrationError.BceidBusinessIdDoesNotMatch,
+
+                _ => PspRegistrationError.GenericError
+              };
+            }
+
+            return TypedResults.BadRequest(new PspRegistrationErrorResponse
+            {
+              ErrorCode = errorCode
             });
           }
 
@@ -106,7 +120,9 @@ public enum PspRegistrationError
   /// <summary>The invitation is not in correct status for registration</summary>
   PortalInvitationWrongStatus,
   /// <summary>The BCeID Business ID doesn't match expected value</summary>
-  BceidBusinessIdDoesNotMatch
+  BceidBusinessIdDoesNotMatch,
+  /// <summary>A generic error occurred during registration</summary>
+  GenericError
 }
 
 /// <summary>

src/ECER.Clients.PSPPortal/ecer.clients.pspportal.client/src/components/pages/Dashboard.vue

@@ -94,8 +94,10 @@ export default defineComponent({
           case "PostSecondaryInstitutionNotFound":
             this.router.replace("/access-denied");
             break;
+          case "GenericError":
           default:
             this.router.replace("/generic-registration-error");
+            break;
         }
         return;
       }

src/ECER.Clients.PSPPortal/ecer.clients.pspportal.client/src/types/openapi.d.ts

@@ -48,7 +48,8 @@ declare namespace Components {
       | "PostSecondaryInstitutionNotFound"
       | "PortalInvitationTokenInvalid"
       | "PortalInvitationWrongStatus"
-      | "BceidBusinessIdDoesNotMatch";
+      | "BceidBusinessIdDoesNotMatch"
+      | "GenericError";
     /**
      * Error response for PSP user registration failures. Returns only the error code for frontend handling.
      */