Requirement to create many enforcements (#634)

* Inspection requirements refinements

* requirement - enforcement many to many

* requirement to create many enforcement actions

Author: dinesh-aot

compliance-api/src/compliance_api/models/administrative_penalty.py

@@ -330,29 +330,6 @@ def get_count_by_project_nd_case_file_id(cls, project_id: int, case_file_id: int
         )
         return result.administrative_penalty_count if result else 0
 
-    @classmethod
-    def does_administrative_penalty_exists_by_requirement_ids(
-        cls, requirement_ids: list[int], administrative_penalty_id: int = None
-    ):
-        """Check if an administrative penalty exists by requirement ids."""
-        query = cls.query.join(
-            AdministrativePenaltyInspectionRequirementMap,
-            AdministrativePenaltyInspectionRequirementMap.administrative_penalty_id
-            == cls.id,
-        ).filter(
-            AdministrativePenaltyInspectionRequirementMap.inspection_requirement_id.in_(
-                requirement_ids
-            ),
-            AdministrativePenaltyInspectionRequirementMap.is_deleted.is_(False),
-            AdministrativePenaltyInspectionRequirementMap.is_active.is_(True),
-            cls.is_deleted.is_(False),
-        )
-
-        if administrative_penalty_id:
-            query = query.filter(cls.id != administrative_penalty_id)
-
-        return query.first() is not None
-
     @classmethod
     def get_administrative_penalties_by_case_files(
         cls, case_file_ids: list[int], open_aps_only: bool = False

compliance-api/src/compliance_api/models/charge_recommendation.py

@@ -376,37 +376,3 @@ def get_count_by_project_nd_case_file_id(
             .first()
         )
         return result.charge_recommendation_count if result else 0
-
-    @classmethod
-    @with_session
-    def does_charge_recommendation_exists_by_requirement_ids(
-        cls,
-        requirement_ids: list[int],
-        charge_recommendation_id: int = None,
-        session=None,
-    ):
-        """Check if a charge recommendation exists by requirement ids."""
-        query = (
-            session.query(cls)
-            .join(
-                ChargeRecommendationInspectionRequirementMap,
-                cls.id
-                == ChargeRecommendationInspectionRequirementMap.charge_recommendation_id,
-            )
-            .filter(
-                and_(
-                    ChargeRecommendationInspectionRequirementMap.inspection_requirement_id.in_(
-                        requirement_ids
-                    ),
-                    cls.is_active.is_(True),
-                    cls.is_deleted.is_(False),
-                    ChargeRecommendationInspectionRequirementMap.is_active.is_(True),
-                    ChargeRecommendationInspectionRequirementMap.is_deleted.is_(False),
-                )
-            )
-        )
-
-        if charge_recommendation_id:
-            query = query.filter(cls.id != charge_recommendation_id)
-
-        return query.first() is not None

compliance-api/src/compliance_api/models/order.py

@@ -246,29 +246,6 @@ def get_count_by_project_nd_case_file_id(cls, project_id: int, case_file_id: int
         )
         return result.order_count if result else 0
 
-    @classmethod
-    def does_order_exists_by_requirement_ids(
-        cls, requirement_ids: list[int], order=None
-    ):
-        """Check if an order exists by requirement ids."""
-        query = cls.query.join(
-            OrderInspectionRequirementMap,
-            OrderInspectionRequirementMap.order_id == cls.id,
-        ).filter(
-            OrderInspectionRequirementMap.inspection_requirement_id.in_(
-                requirement_ids
-            ),
-            cls.is_deleted.is_(False),
-        )
-
-        # Only filter by order_replace_status if order is provided
-        if order and hasattr(order, "order_replace_status"):
-            query = query.filter(cls.order_replace_status == order.order_replace_status)
-
-        if order and order.id:
-            query = query.filter(cls.id != order.id)
-        return query.first()
-
     @classmethod
     def get_by_order_number(cls, order_number: str):
         """Find an order by order number."""

compliance-api/src/compliance_api/models/restorative_justice.py

@@ -301,37 +301,3 @@ def get_count_by_project_nd_case_file_id(
             )
             .count()
         )
-
-    @classmethod
-    @with_session
-    def does_restorative_justice_exists_by_requirement_ids(
-        cls,
-        requirement_ids: list[int],
-        restorative_justice_id: int = None,
-        session=None,
-    ):
-        """Check if a restorative justice exists by requirement ids."""
-        query = (
-            session.query(cls)
-            .join(
-                RestorativeJusticeInspectionRequirementMap,
-                cls.id
-                == RestorativeJusticeInspectionRequirementMap.restorative_justice_id,
-            )
-            .filter(
-                and_(
-                    RestorativeJusticeInspectionRequirementMap.inspection_requirement_id.in_(
-                        requirement_ids
-                    ),
-                    cls.is_active.is_(True),
-                    cls.is_deleted.is_(False),
-                    RestorativeJusticeInspectionRequirementMap.is_active.is_(True),
-                    RestorativeJusticeInspectionRequirementMap.is_deleted.is_(False),
-                )
-            )
-        )
-
-        if restorative_justice_id:
-            query = query.filter(cls.id != restorative_justice_id)
-
-        return query.first() is not None

compliance-api/src/compliance_api/models/violation_ticket.py

@@ -265,24 +265,6 @@ def get_count_by_project_and_case_file_id(cls, project_id: int, case_file_id: in
         )
         return query.count()
 
-    @classmethod
-    def does_violation_ticket_exists_by_requirement_ids(
-        cls, requirement_ids: list[int], violation_ticket_id: int = None
-    ):
-        """Check if a violation ticket exists by requirement ids."""
-        query = cls.query.join(
-            ViolationTicketInspectionRequirementMap,
-            ViolationTicketInspectionRequirementMap.violation_ticket_id == cls.id,
-        ).filter(
-            ViolationTicketInspectionRequirementMap.inspection_requirement_id.in_(
-                requirement_ids
-            ),
-            cls.is_deleted.is_(False),
-        )
-        if violation_ticket_id:
-            query = query.filter(cls.id != violation_ticket_id)
-        return query.first()
-
     @classmethod
     def get_by_vt_number(cls, vt_number: str):
         """Find a violation ticket by vt number."""

compliance-api/src/compliance_api/models/warning_letter.py

@@ -246,21 +246,3 @@ def get_count_by_project_nd_case_file_id(cls, project_id: int, case_file_id: int
             .first()
         )
         return result.warning_letter_count if result else 0
-
-    @classmethod
-    def does_warning_letter_exists_by_requirement_ids(
-        cls, requirement_ids: list[int], warning_letter_id: int = None
-    ):
-        """Check if a warning letter exists by requirement ids."""
-        query = cls.query.join(
-            WarningLetterInspectionRequirementMap,
-            WarningLetterInspectionRequirementMap.warning_letter_id == cls.id,
-        ).filter(
-            WarningLetterInspectionRequirementMap.inspection_requirement_id.in_(
-                requirement_ids
-            ),
-            cls.is_deleted.is_(False),
-        )
-        if warning_letter_id:
-            query = query.filter(cls.id != warning_letter_id)
-        return query.first()

compliance-api/src/compliance_api/resources/case_file.py

@@ -199,6 +199,7 @@ class CaseFile(Resource):
     """Resource for managing a single CaseFile."""
 
     @staticmethod
+    @auth.require
     @ApiHelper.swagger_decorators(API, endpoint_description="Fetch a CaseFile by id")
     @API.response(code=200, model=case_file_list_model, description="Success")
     @API.response(404, "Not Found")
@@ -340,6 +341,7 @@ def post(case_file_id):
         return CaseFileLinkSchema().dump(created_link), HTTPStatus.CREATED
 
     @staticmethod
+    @auth.require
     @ApiHelper.swagger_decorators(API, endpoint_description="Get all linked case files")
     @API.response(code=200, model=[case_file_option_schema], description="Success")
     def get(case_file_id):

compliance-api/src/compliance_api/resources/complaint.py

@@ -184,6 +184,7 @@ class Complaint(Resource):
     """Resource for managing a single Complaint."""
 
     @staticmethod
+    @auth.require
     @ApiHelper.swagger_decorators(API, endpoint_description="Fetch a complaint by id")
     @API.response(code=200, model=complaint_list_model, description="Success")
     @API.response(404, "Not Found")
@@ -228,6 +229,7 @@ class ComplaintRequirementDetails(Resource):
     """Resource for managing a Complaint requirement details.."""
 
     @staticmethod
+    @auth.require
     @ApiHelper.swagger_decorators(
         API, endpoint_description="Fetch a complaint requirement details"
     )
@@ -245,6 +247,7 @@ class ComplaintContact(Resource):
     """Resource for managing a Complaint Contact."""
 
     @staticmethod
+    @auth.require
     @ApiHelper.swagger_decorators(
         API, endpoint_description="Fetch a complaint source contact"
     )

compliance-api/src/compliance_api/resources/section.py

@@ -4,6 +4,8 @@
 
 from flask_restx import Namespace, Resource
 
+from compliance_api.auth import auth
+
 from ..schemas import SectionSchema
 from ..services.section import SectionService
 from ..utils.util import cors_preflight
@@ -23,6 +25,7 @@ class Sections(Resource):
     """Resource for managing sections."""
 
     @staticmethod
+    @auth.require
     @API.response(code=200, description="Success", model=[section_list_model])
     @ApiHelper.swagger_decorators(API, endpoint_description="Fetch all active sections")
     def get():

compliance-api/src/compliance_api/services/administrative_penalty.py

@@ -146,13 +146,6 @@ def create_administrative_penalty(cls, administrative_penalty_data):
             EnforcementActionOptionEnum.ADMINISTRATIVE_PENALTY_RECOMMENDATION.value,
         )
 
-        # Check if administrative penalty already exists for the given requirements
-        if AdministrativePenalty.does_administrative_penalty_exists_by_requirement_ids(
-            administrative_penalty_data.get("inspection_requirement_ids", []),
-        ):
-            raise UnprocessableEntityError(
-                "Administrative Penalty already exists for these requirements."
-            )
         administrative_penalty_obj = _create_ap_object(
             inspection, administrative_penalty_data
         )
@@ -202,17 +195,6 @@ def update_administrative_penalty(cls, administrative_penalty_id, update_data):
                 EnforcementActionOptionEnum.ADMINISTRATIVE_PENALTY_RECOMMENDATION.value,
             )
 
-        # Check if administrative penalty already exists for the given requirements
-        if (
-            requirement_ids
-            and AdministrativePenalty.does_administrative_penalty_exists_by_requirement_ids(
-                requirement_ids, administrative_penalty_id
-            )
-        ):
-            raise UnprocessableEntityError(
-                "Administrative Penalty already exists for these requirements."
-            )
-
         # Validate penalty_amount if decision is provided
         if (
             update_data.get("decision")
@@ -349,16 +331,6 @@ def link(cls, administrative_penalty_id, link):
             requirement_ids,
             EnforcementActionOptionEnum.ADMINISTRATIVE_PENALTY_RECOMMENDATION.value,
         )
-        # Check if administrative penalty already exists for the given requirements
-        if (
-            requirement_ids
-            and AdministrativePenalty.does_administrative_penalty_exists_by_requirement_ids(
-                requirement_ids, administrative_penalty_id
-            )
-        ):
-            raise UnprocessableEntityError(
-                "Administrative Penalty already exists for these requirements."
-            )
         existing_requirements = (
             AdministrativePenaltyInspectionRequirementMap.get_by_inspection_and_administrative_penalty_id(
                 inspection_id, administrative_penalty_id