[Comp-795] fix strict lint, remove unused mock data, removed unused e… (#749)

Author: tolkamps1

README.md

@@ -80,7 +80,7 @@ Change to the front-end directory:
 * `cd compliance-web`
 
 ### 2. Requirements
-- [Node.js](https://nodejs.org/en/) 18
+- [Node.js](https://nodejs.org/en/) 24
 
 ### 3. Install Dependencies
 Install necessary npm packages:

compliance-web/cypress/components/_components/_Shared/_MasterDataTable/utils.cy.ts

@@ -1,64 +1,9 @@
 /// <reference types="cypress" />
 import {
   exportToCsv,
-  getSelectFilterOptions,
-  rowsPerPageOptions,
-  searchFilter,
 } from "@/components/Shared/MasterDataTable/utils";
 import { MRT_RowData, MRT_TableInstance } from "material-react-table";
 
-describe("Utility Functions", () => {
-  describe("getSelectFilterOptions", () => {
-    it("returns formatted options with proper labels and values", () => {
-      const mockData = [
-        { id: 1, name: "Option 1" },
-        { id: 2, name: "Option 2" },
-        { id: 3, name: null },
-      ];
-
-      const options = getSelectFilterOptions(mockData, "name");
-
-      expect(options).to.deep.equal([
-        { text: "(Blanks)", value: "" },
-        { text: "Option 1", value: "Option 1" },
-        { text: "Option 2", value: "Option 2" },
-      ]);
-    });
-
-    it("sorts options correctly, placing blanks at the top", () => {
-      const mockData = [
-        { id: 1, name: "Zebra" },
-        { id: 2, name: "Apple" },
-        { id: 3, name: null },
-      ];
-
-      const options = getSelectFilterOptions(mockData, "name");
-
-      expect(options).to.deep.equal([
-        { text: "(Blanks)", value: "" },
-        { text: "Apple", value: "Apple" },
-        { text: "Zebra", value: "Zebra" },
-      ]);
-    });
-  });
-
-  describe("rowsPerPageOptions", () => {
-    it("returns default options when no data size is provided", () => {
-      const options = rowsPerPageOptions();
-      expect(options).to.deep.equal([
-        { value: 15, label: "15" },
-        { value: 10, label: "All" },
-      ]);
-    });
-
-    it("returns options with a custom data size", () => {
-      const options = rowsPerPageOptions(20);
-      expect(options).to.deep.equal([
-        { value: 15, label: "15" },
-        { value: 20, label: "All" },
-      ]);
-    });
-  });
 
   describe("exportToCsv", () => {
     it("exports table data to CSV correctly", async () => {
@@ -105,42 +50,3 @@ describe("Utility Functions", () => {
       cy.get("@createObjectURL").should("be.calledOnce");
     });
   });
-
-  describe("searchFilter", () => {
-    it("returns true when filter value is a substring of the row value", () => {
-      const row = {
-        getValue: () => "apple pie",
-      };
-  
-      const result = searchFilter(row, "id", "apple");
-      expect(result).to.be.true;
-    });
-  
-    it("returns false when filter value is not present in the row value", () => {
-      const row = {
-        getValue: () => "apple pie",
-      };
-  
-      const result = searchFilter(row, "id", "banana");
-      expect(result).to.be.false;
-    });
-  
-    it("returns true when filter value is an array containing a matching substring", () => {
-      const row = {
-        getValue: () => "apple pie",
-      };
-  
-      const result = searchFilter(row, "id", ["apple", "banana"]);
-      expect(result).to.be.true;
-    });
-  
-    it("returns false when filter value is an array not containing any matching substrings", () => {
-      const row = {
-        getValue: () => "apple pie",
-      };
-  
-      const result = searchFilter(row, "id", ["banana", "cherry"]);
-      expect(result).to.be.false;
-    });
-  });
-});

compliance-web/cypress/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../tsconfig.json",
+  "extends": "../tsconfig.app.json",
   "compilerOptions": {
     "target": "es6",
     "lib": ["es6", "dom"],

compliance-web/src/components/App/CaseFiles/Profile/CaseFileComplaintsTable.tsx

@@ -5,7 +5,6 @@ import { INITIATION } from "@/utils/constants";
 import dateUtils from "@/utils/dateUtils";
 import { ChevronRight, ExpandLessRounded } from "@mui/icons-material";
 import {
-  Link,
   Chip,
   Accordion,
   AccordionSummary,
@@ -92,16 +91,14 @@ const CaseFileComplaintsTable = ({ caseFile }: { caseFile: CaseFile }) => {
                 >
                   <Box display={"flex"} alignItems={"center"} gap={0.5}>
                     {isExpanded ? <ExpandLessRounded /> : <ChevronRight />}
-                    <Link
-                      component={RouterLink}
+                    <RouterLink
                       to="/ce-database/complaints/$complaintNumber"
                       params={{
                         complaintNumber: complaint.complaint_number,
                       }}
-                      underline="hover"
                     >
                       {complaint.complaint_number}
-                    </Link>
+                    </RouterLink>
                     <Chip
                       label={complaint.status}
                       data-testid="status-chip"

compliance-web/src/components/App/CaseFiles/Profile/CaseFileInspectionsTable.tsx

@@ -103,7 +103,6 @@ const CaseFileInspectionsTable = ({ caseFile }: { caseFile: CaseFile }) => {
           inspection={inspection as Inspection}
           enforcementOrder={order}
           staffUsersList={staffUsersList || []}
-          isReadonlyMode={true}
         />
       ),
       width: DRAWER_WIDTHS.ENFORCEMENT_DRAWER,
@@ -211,16 +210,14 @@ const CaseFileInspectionsTable = ({ caseFile }: { caseFile: CaseFile }) => {
                 >
                   <Box display={"flex"} alignItems={"center"} gap={0.5}>
                     {isExpanded ? <ExpandLessRounded /> : <ChevronRight />}
-                    <Link
-                      component={RouterLink}
+                    <RouterLink
                       to="/ce-database/inspections/$inspectionNumber"
                       params={{
                         inspectionNumber: inspection.ir_number,
                       }}
-                      underline="hover"
                     >
                       {inspection.ir_number}
-                    </Link>
+                    </RouterLink>
                     <Chip
                       label={inspection.inspection_status}
                       data-testid="status-chip"

compliance-web/src/components/App/Inspections/InspectionFormUtils.ts

@@ -205,6 +205,7 @@ export const formatInAttendance = (
         } else if (typeof attendance.data === "string") {
           return attendance.data;
         }
+        return attendance.attendance_option.name;
       } else {
         if (
           attendance.attendance_option.id ===

compliance-web/src/components/App/Inspections/Profile/Enforcements/AdministrativePenalty/AdministrativePenaltyCreationOptions.tsx

@@ -184,7 +184,7 @@ const AdministrativePenaltyCreationOptions: FC<AdministrativePenaltyCreationOpti
             options={openAPs ?? []}
             getOptionLabel={(option) => {
               if (typeof option === 'number') {
-                const foundOption = openAPs.find(ap => ap.id === option);
+                const foundOption = openAPs?.find(ap => ap.id === option);
                 return foundOption?.administrative_penalty_number || '';
               }
               return option.administrative_penalty_number;

compliance-web/src/components/App/Inspections/Profile/Enforcements/EnforcementUtils.ts

@@ -43,36 +43,6 @@ export const orderSchema = baseEnforcementSchema.shape({
 
 export type OrderFormType = yup.InferType<typeof orderSchema>;
 
-export const initOrderFormData: OrderFormType = {
-  requirements: [],
-  isHistoricalRecord: false,
-  manualOrderNumber: undefined,
-  linkedOrderNumber: undefined,
-};
-
-// Enforcement type detection functions
-export const isEnforcementOrder = (requirement: InspectionRequirement): boolean => {
-  return requirement.enforcement_action_data.some(
-    (enforcement) => enforcement.id === EnforcementActionEnum.ORDER
-  );
-};
-
-export const isEnforcementWarningLetter = (requirement: InspectionRequirement): boolean => {
-  return requirement.enforcement_action_data.some(
-    (enforcement) => enforcement.id === EnforcementActionEnum.WARNING_LETTER
-  );
-};
-
-export const getEnforcementTypeFromRequirement = (requirement: InspectionRequirement): EnforcementActionEnum | null => {
-  if (isEnforcementOrder(requirement)) {
-    return EnforcementActionEnum.ORDER;
-  }
-  if (isEnforcementWarningLetter(requirement)) {
-    return EnforcementActionEnum.WARNING_LETTER;
-  }
-  return null;
-};
-
 // Requirement data processing functions
 export const prepNonProceededRequirements = (
   {

compliance-web/src/components/App/Inspections/Profile/Enforcements/Orders/OrderCreationOptions.tsx

@@ -173,10 +173,10 @@ const OrderCreationOptions: FC<OrderCreationOptionsProps> = ({
             options={openOrders ?? []}
             getOptionLabel={(option) => {
               if (typeof option === 'number') {
-                const foundOption = openOrders.find(o => o.id === option);
+                const foundOption = openOrders?.find(o => o.id === option);
                 return foundOption?.order_number || '';
               }
-              return option.order_number;
+              return option.order_number || '';
             }}
             isOptionEqualToValue={(option, value) => {
               if (typeof value === 'number') {

compliance-web/src/components/App/Inspections/Profile/Enforcements/ViolationTicket/ViolationTicketCreateModal.tsx

@@ -47,7 +47,6 @@ type ViolationTicketCreateModalProps = {
   requirement?: InspectionRequirement;
   nonProceededRequirements?: InspectionRequirement[];
   enforcementAction: EnforcementActionEnum;
-  isPrimaryOfficerOrSuperUser: boolean;
   onSubmit: (data: ViolationTicket) => void;
 };
 
@@ -56,7 +55,6 @@ const ViolationTicketCreateModal: FC<ViolationTicketCreateModalProps> = ({
   requirementsList,
   requirement,
   nonProceededRequirements,
-  isPrimaryOfficerOrSuperUser,
   enforcementAction,
   onSubmit,
 }) => {
@@ -129,7 +127,6 @@ const ViolationTicketCreateModal: FC<ViolationTicketCreateModalProps> = ({
         requirement={requirement}
         nonProceededRequirements={nonProceededRequirements}
         enforcementAction={enforcementAction}
-        isPrimaryOfficerOrSuperUser={isPrimaryOfficerOrSuperUser}
         title="Create Violation Ticket"
         onSubmit={handleBaseSubmit}
         isLoading={isPendingViolationTicket}