diff --git a/compliance-api/requirements/dev.txt b/compliance-api/requirements/dev.txt index ec956c29..d43b8268 100644 --- a/compliance-api/requirements/dev.txt +++ b/compliance-api/requirements/dev.txt @@ -7,7 +7,6 @@ pylint-flask pytest pytest-cov pytest-env -pytest-dotenv pytest-mock requests flake8==4.0.1 diff --git a/compliance-api/src/compliance_api/services/case_file.py b/compliance-api/src/compliance_api/services/case_file.py index 86e6ca26..43b66996 100644 --- a/compliance-api/src/compliance_api/services/case_file.py +++ b/compliance-api/src/compliance_api/services/case_file.py @@ -24,6 +24,7 @@ from compliance_api.models.complaint import ComplaintStatusEnum from compliance_api.models.db import db, session_scope from compliance_api.models.inspection import Inspection as InspectionModel +from compliance_api.models.inspection.inspection_enum import InspectionStatusEnum from compliance_api.models.order import Order as OrderModel from compliance_api.models.project import Project as ProjectModel from compliance_api.models.restorative_justice import RestorativeJustice as RestorativeJusticeModel @@ -761,8 +762,11 @@ def _process_case_level_items(case_file_id: int, open_items: dict) -> list: for row in case_level_query: if row.inspection_id and row.inspection_id not in all_inspection_ids: all_inspection_ids.add(row.inspection_id) - # Add all inspection items, regardless of IR status - open_items["inspections"].append(_build_inspection_item(row)) + # Only add inspections that are open to the open items list, + # closed inspections are not considered open items but we + # want to track their IDs for enforcement action checks + if row.inspection_status == InspectionStatusEnum.OPEN: + open_items["inspections"].append(_build_inspection_item(row)) if row.complaint_id and row.complaint_id not in processed_complaints: processed_complaints.add(row.complaint_id)