Merge pull request #166 from don-aot/CONDITIONS-task#152

CR-152:Issue with “Time associated with submission milestone” Attribute

Author: don-aot

condition-web/src/components/ConditionDetails/ConditionAttribute/DynamicFieldRenderer.tsx

@@ -154,19 +154,19 @@ const DynamicFieldRenderer: React.FC<DynamicFieldRendererProps> = ({
         }
     }, [attributeData.key, attributeData.value]);
 
+    const { setValue } = attributeData;
     useEffect(() => {
         if (timeUnit) {
             if (timeUnit === "N/A") {
-                attributeData.setValue(timeUnit); // Only set the time unit
+                setValue(timeUnit); // Only set the time unit
             } else {
                 const value = customTimeValue || timeValue;
-                if (value) {
-                    attributeData.setValue(`${value} ${timeUnit} ${timeDirection}`);
+                if (value && timeDirection) {
+                    setValue(`${value} ${timeUnit} ${timeDirection}`);
                 }
             }
         }
-    }, [timeValue, timeUnit, timeDirection, customTimeValue, attributeData]);
-
+    }, [timeValue, timeUnit, timeDirection, customTimeValue, setValue]);
     const handleTimeUnitChange = (e: SelectChangeEvent<string>) => {
         const selectedUnit = e.target.value;
         setTimeUnit(selectedUnit);