Skip to content

Commit 6c93068

Browse files
authored
Merge pull request #157 from don-aot/CONDITIONS-task#157
CR-157:Disable the selection of conditions from OG document if it has been amended
2 parents 0a392d6 + 4fb9f1c commit 6c93068

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

condition-api/src/condition_api/services/condition_service.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,7 @@ def get_all_conditions(
136136
),
137137
else_=False # At least one condition is not met
138138
).label('is_approved'), # Derived column for the calculated approval status
139+
conditions.is_active,
139140
conditions.is_standard_condition,
140141
conditions.topic_tags,
141142
conditions.subtopic_tags,
@@ -169,6 +170,7 @@ def get_all_conditions(
169170
)
170171
)
171172
)
173+
.filter(conditions.is_active.is_(True))
172174
.group_by(
173175
conditions.id,
174176
conditions.condition_name,
@@ -177,6 +179,7 @@ def get_all_conditions(
177179
conditions.is_approved,
178180
conditions.is_condition_attributes_approved,
179181
conditions.is_topic_tags_approved,
182+
conditions.is_active,
180183
conditions.is_standard_condition,
181184
conditions.topic_tags,
182185
conditions.subtopic_tags,
@@ -201,6 +204,7 @@ def get_all_conditions(
201204
"condition_number": row.condition_number,
202205
"condition_text": row.condition_text,
203206
"is_approved": row.is_approved,
207+
"is_active": row.is_active,
204208
"is_standard_condition": row.is_standard_condition,
205209
"topic_tags": row.topic_tags,
206210
"subtopic_tags": row.subtopic_tags,

condition-web/src/models/Condition.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ export interface ConditionModel {
1515
effective_document_id?: string;
1616
year_issued?: number;
1717
is_approved?: boolean;
18+
is_active?: boolean;
1819
topic_tags?: string[];
1920
is_topic_tags_approved?: boolean;
2021
is_condition_attributes_approved?: boolean;

0 commit comments

Comments
 (0)