2419 Fix E2E Tests (#2510)

* fix: e2e tests

* fix: alcs txt naming

* chore: update comments

Author: PaulGreywal

e2e/pages/alcs/applicant-info-page/parcels-section.ts

@@ -32,7 +32,11 @@ export class ParcelsSection {
     }
     await expect(this.isFarmText(parcelNumber)).toHaveText(parcel.isFarm ? 'Yes' : 'No');
     await expect(this.civicAddressText(parcelNumber)).toHaveText(parcel.civicAddress);
-    await expect(this.certificateOfTitleText(parcelNumber)).toHaveText(this.fileName(parcel.certificateOfTitlePath));
+
+    // Check each child element for certificate of title (mobile/desktop links)
+    for (const text of await this.certificateOfTitleText(parcelNumber).locator("> *").all()) {
+      await expect(text).toHaveText(this.fileName(parcel.certificateOfTitlePath));
+    }
   }
 
   async expectParcelOwners(parcelNumber: number, owners: ParcelOwnerDetails[]) {

e2e/pages/alcs/applicant-info-page/tur-proposal-section.ts

@@ -8,7 +8,6 @@ export class TURProposalSection {
   readonly stepsToReduceImpactText: Locator;
   readonly alternativeLandText: Locator;
   readonly totalAreaText: Locator;
-  readonly allOwnersNotifiedText: Locator;
   readonly proofOfServingNoticeText: Locator;
   readonly proposalMapText: Locator;
 
@@ -29,8 +28,15 @@ export class TURProposalSection {
     await expect(this.stepsToReduceImpactText).toHaveText(proposal.stepsToReduceImpact);
     await expect(this.alternativeLandText).toHaveText(proposal.alternativeLand);
     await expect(this.totalAreaText).toHaveText(`${proposal.totalArea} ha`);
-    await expect(this.proofOfServingNoticeText).toHaveText(this.fileName(proposal.proofOfServingNoticePath));
-    await expect(this.proposalMapText).toHaveText(this.fileName(proposal.proposalMapPath));
+    
+    // ALCS has multiple files with *ngFor, so check each child element
+    for (const text of await this.proofOfServingNoticeText.locator("> *").all()) {
+      await expect(text).toHaveText(this.fileName(proposal.proofOfServingNoticePath));
+    }
+    
+    for (const text of await this.proposalMapText.locator("> *").all()) {
+      await expect(text).toHaveText(this.fileName(proposal.proposalMapPath));
+    }
   }
 
   fileName(path: string): string {

e2e/pages/portal/review-and-submit-page/parcels-section.ts

@@ -32,7 +32,12 @@ export class ParcelsSection {
     }
     await expect(this.isFarmText(parcelNumber)).toHaveText(parcel.isFarm ? 'Yes' : 'No');
     await expect(this.civicAddressText(parcelNumber)).toHaveText(parcel.civicAddress);
-    await expect(this.certificateOfTitleText(parcelNumber)).toHaveText(this.fileName(parcel.certificateOfTitlePath));
+
+    // Check each child element for certificate of title (mobile/desktop links)
+    for (const text of await this.certificateOfTitleText(parcelNumber).locator("> *").all()) {
+      await expect(text).toHaveText(this.fileName(parcel.certificateOfTitlePath));
+    }
+
     await expect(this.confirmationText(parcelNumber)).toHaveText(parcel.isConfirmed ? 'Yes' : 'No');
   }
 

e2e/pages/portal/review-and-submit-page/tur-proposal-section.ts

@@ -31,8 +31,16 @@ export class TURProposalSection {
     await expect(this.alternativeLandText).toHaveText(proposal.alternativeLand);
     await expect(this.totalAreaText).toHaveText(`${proposal.totalArea} ha`);
     await expect(this.allOwnersNotifiedText).toHaveText(proposal.isConfirmed ? 'Yes' : 'No');
-    await expect(this.proofOfServingNoticeText).toHaveText(this.fileName(proposal.proofOfServingNoticePath));
-    await expect(this.proposalMapText).toHaveText(this.fileName(proposal.proposalMapPath));
+
+    // Check each child element for proof of serving notice
+    for (const text of await this.proofOfServingNoticeText.locator("> *").all()) {
+      await expect(text).toHaveText(this.fileName(proposal.proofOfServingNoticePath));
+    }
+
+    // Check each child element for proposal map
+    for (const text of await this.proposalMapText.locator("> *").all()) {
+      await expect(text).toHaveText(this.fileName(proposal.proposalMapPath));
+    }
   }
 
   fileName(path: string): string {