Responsible Parties QA III (#2604)

* fix: addressed qa changes part III

* fix: fix submitter fields to resolve save to draft bug

Author: PaulGreywal

alcs-frontend/src/app/features/compliance-and-enforcement/details/responsible-parties/responsible-parties.component.ts

@@ -261,12 +261,18 @@ export class ResponsiblePartiesDetailsComponent implements OnInit, OnDestroy {
   }
 
   async saveResponsibleParties() {
-    // Force immediate save of all form changes in the responsible parties component ( this bypasses the debounce and saves immediately )
+    // Force immediate save of all form changes in the responsible parties component
     if (this.responsiblePartiesComponent) {
-      await this.responsiblePartiesComponent.saveAllForms();
+      const success = await this.responsiblePartiesComponent.saveAllForms();
+      
+      if (!success) {
+        // Validation failed - don't navigate, show error
+        this.toastService.showErrorToast('Please fill in all required fields before saving');
+        return;
+      }
     }
 
-    // Navigate immediately
+    // Navigate only if validation passed
     this.router.navigate(['..'], { relativeTo: this.route });
 
     // Show success toast after navigation

alcs-frontend/src/app/features/compliance-and-enforcement/draft/draft.component.ts

@@ -321,7 +321,7 @@ export class DraftComponent implements OnInit, AfterViewInit, OnDestroy {
       if (submitterUuid) {
         await firstValueFrom(this.complianceAndEnforcementSubmitterService.update(submitterUuid, submitterUpdate));
       } else {
-        this.submitter = await firstValueFrom(this.complianceAndEnforcementSubmitterService.create(submitterUpdate));
+        this.submitter = await firstValueFrom(this.complianceAndEnforcementSubmitterService.create({ ...submitterUpdate, fileUuid: this.file.uuid }));
       }
 
       if (this.property?.uuid) {

alcs-frontend/src/app/features/compliance-and-enforcement/responsible-parties/responsible-parties.component.ts

@@ -508,7 +508,20 @@ export class ResponsiblePartiesComponent implements OnInit, OnDestroy {
     this.showRequiredError = true;
   }
 
-  async saveAllForms(): Promise<void> {
+  async saveAllForms(): Promise<boolean> {
+    // Mark all forms as touched to show validation errors
+    for (let i = 0; i < this.form.length; i++) {
+      const partyForm = this.form.at(i);
+      partyForm.markAllAsTouched();
+    }
+
+    // Check if all forms are valid
+    const allFormsValid = this.form.controls.every(form => form.valid);
+    
+    if (!allFormsValid) {
+      return false; // Validation failed
+    }
+
     // Force immediate save of all form changes, bypassing debounce
     const savePromises: Promise<void>[] = [];
 
@@ -524,6 +537,7 @@ export class ResponsiblePartiesComponent implements OnInit, OnDestroy {
 
     // Wait for all saves to complete
     await Promise.all(savePromises);
+    return true; // Success
   }
 
   ngOnDestroy(): void {

alcs-frontend/src/app/services/compliance-and-enforcement/responsible-parties/responsible-parties.service.ts

@@ -2,14 +2,14 @@ import { HttpClient, HttpParams } from '@angular/common/http';
 import { Injectable } from '@angular/core';
 import { firstValueFrom, Observable } from 'rxjs';
 import { environment } from '../../../../environments/environment';
+import { OwnerDto, SubmissionOwnersDto } from '../../../shared/document-upload-dialog/document-upload-dialog.dto';
 import {
-  ResponsiblePartyDto,
   CreateResponsiblePartyDto,
-  UpdateResponsiblePartyDto,
   FOIPPACategory,
+  ResponsiblePartyDto,
   ResponsiblePartyType,
+  UpdateResponsiblePartyDto,
 } from './responsible-parties.dto';
-import { OwnerDto, SubmissionOwnersDto } from '../../../shared/document-upload-dialog/document-upload-dialog.dto';
 
 @Injectable({
   providedIn: 'root',
@@ -24,16 +24,20 @@ export class ResponsiblePartiesService {
   }
 
   async fetchSubmission(fileNumber: string): Promise<SubmissionOwnersDto> {
-    const responsibleParties = await this.fetchByFileNumber(fileNumber, ResponsiblePartyType.PROPERTY_OWNER);
-    const responsiblePartiesOwners: OwnerDto[] = responsibleParties.map((party) => ({
-      ...party,
-      displayName: '',
-      type: {
-        label: '',
-        code: party.foippaCategory === FOIPPACategory.ORGANIZATION ? 'ORGZ' : '',
-        description: '',
-      },
-    }));
+    const responsibleParties = await this.fetchByFileNumber(fileNumber);
+    const responsiblePartiesOwners: OwnerDto[] = responsibleParties
+      .filter((party) => party.foippaCategory === FOIPPACategory.ORGANIZATION)
+      .map((party) => ({
+        uuid: party.uuid,
+        displayName: party.organizationName || '',
+        organizationName: party.organizationName,
+        corporateSummaryUuid: undefined,
+        type: {
+          label: '',
+          code: party.foippaCategory === FOIPPACategory.ORGANIZATION ? 'ORGZ' : '',
+          description: '',
+        },
+      }));
 
     return {
       owners: responsiblePartiesOwners,

alcs-frontend/src/app/shared/document-upload-dialog/document-upload-dialog.component.ts

@@ -261,6 +261,15 @@ export class DocumentUploadDialogComponent implements OnInit, OnDestroy {
 
   async prepareCertificateOfTitleUpload(uuid?: string) {
     this.source.setValue(DOCUMENT_SOURCE.APPLICANT);
+    
+    // If fixedParcel is provided, use it and don't require validation
+    if (this.data.fixedParcel) {
+      this.parcelId.setValue(this.data.fixedParcel.uuid);
+      this.parcelId.clearValidators();
+      this.parcelId.updateValueAndValidity();
+      return;
+    }
+    
     this.parcelId.setValidators([Validators.required]);
     this.parcelId.updateValueAndValidity();