Skip to content

Commit fa000da

Browse files
authored
Merge pull request #2401 from bcgov/dependabot/npm_and_yarn/services/develop/npm-minor-and-patch-3a3406b815
ALCS-000: Bump the npm-minor-and-patch group across 1 directory with 38 updates
2 parents 44f7533 + 26db6cb commit fa000da

File tree

4 files changed

+3856
-2433
lines changed

4 files changed

+3856
-2433
lines changed

services/apps/alcs/src/alcs/planning-review/planning-review.service.spec.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ describe('PlanningReviewService', () => {
3333
mockFileNumberService = createMock();
3434
mockLocalGovernmentService = createMock();
3535
mockCardService = createMock();
36+
mockCodeService = createMock();
3637

3738
const module: TestingModule = await Test.createTestingModule({
3839
imports: [

services/apps/alcs/src/main.ts

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,23 @@ import {
1010
import { DocumentBuilder, SwaggerModule } from '@nestjs/swagger';
1111
import * as config from 'config';
1212
import { ClsMiddleware } from 'nestjs-cls';
13-
import { S3StreamLogger } from 's3-streamlogger';
13+
import { S3StreamLogger, S3StreamLoggerOptions } from 's3-streamlogger';
1414
import { install } from 'source-map-support';
1515
import { SPLAT } from 'triple-beam';
1616
import * as winston from 'winston';
1717
import { createLogger } from 'winston';
1818
import { generateModuleGraph } from './commands/graph';
1919
import { MainModule } from './main.module';
20+
import { S3ClientConfig } from '@aws-sdk/client-s3';
21+
22+
// S3StreamLogger passes its config to S3Client, but doesn't accept all the
23+
// properties of S3ClientConfig. This allows those properties.
24+
interface SafeS3StreamLoggerOptions extends S3StreamLoggerOptions {
25+
config: S3StreamLoggerOptions['config'] & {
26+
forcePathStyle: boolean;
27+
endpoint: string;
28+
};
29+
}
2030

2131
const registerSwagger = (app: NestFastifyApplication) => {
2232
const documentBuilderConfig = new DocumentBuilder()
@@ -96,7 +106,7 @@ const registerMultiPart = async (app: NestFastifyApplication) => {
96106
};
97107

98108
function setupLogger() {
99-
const s3Stream = new S3StreamLogger({
109+
const s3StreamOptions: SafeS3StreamLoggerOptions = {
100110
rotate_every: 1000 * 60 * 60 * 24, //1 Day
101111
folder: 'logs',
102112
bucket: config.get<string>('STORAGE.BUCKET'),
@@ -110,7 +120,9 @@ function setupLogger() {
110120
forcePathStyle: true,
111121
endpoint: config.get('STORAGE.URL'),
112122
},
113-
});
123+
};
124+
125+
const s3Stream = new S3StreamLogger(s3StreamOptions);
114126

115127
const timeStampFormat = winston.format.timestamp({
116128
format: 'YYYY-MMM-DD HH:mm:ss',

0 commit comments

Comments
 (0)