remove unnecessary types

Author: mauberti-bc

app/src/features/admin/policies/ManagePoliciesPage.test.tsx

@@ -165,7 +165,7 @@ describe('ManagePoliciesPage', () => {
 
       await waitFor(() => {
         expect(mockGetPolicies).toHaveBeenCalledWith(
-          { search: undefined },
+          { search: '' },
           expect.objectContaining({
             page: 1,
             limit: 10,
@@ -182,7 +182,7 @@ describe('ManagePoliciesPage', () => {
 
       await waitFor(() => {
         expect(mockGetTeams).toHaveBeenCalledWith(
-          { search: undefined },
+          { search: '' },
           expect.objectContaining({
             page: 1,
             limit: 10,

app/src/features/admin/policies/ManagePoliciesPage.tsx

@@ -16,8 +16,7 @@ import { TeamsContainer } from './components/TeamsContainer';
 /**
  * Admin page for managing policies, teams, and team-policy assignments.
  *
- * Assignments are created directly from the Add Assignment dialog.
- * Team and policy grids are for management only and do not drive assignment filtering.
+ * @returns {*}
  */
 export const ManagePoliciesPage = () => {
   const biohubApi = useApi();
@@ -53,8 +52,7 @@ export const ManagePoliciesPage = () => {
   useEffect(() => {
     const apiPagination = toApiPagination(teamPoliciesPaginationModel, teamPoliciesSortModel);
     teamPoliciesDataLoader.load(debouncedTeamPoliciesSearchTerm, apiPagination);
-    // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, []);
+  }, [debouncedTeamPoliciesSearchTerm, teamPoliciesDataLoader, teamPoliciesPaginationModel, teamPoliciesSortModel]);
 
   const debouncedTeamPoliciesRefresh = useDebounce((searchTerm: string) => {
     setDebouncedTeamPoliciesSearchTerm(searchTerm);

app/src/hooks/useServerPaginatedDataGrid.test.ts

@@ -31,7 +31,7 @@ interface ITestResponse {
 
 // Default hook options for tests
 const createDefaultOptions = (overrides = {}) => ({
-  fetcher: vi.fn<(search: string | undefined, pagination: any) => Promise<ITestResponse>>().mockResolvedValue({
+  fetcher: vi.fn<(search: string, pagination: any) => Promise<ITestResponse>>().mockResolvedValue({
     items: [{ id: '1', name: 'Test' }],
     pagination: { total: 1 }
   }),
@@ -132,7 +132,7 @@ describe('useServerPaginatedDataGrid', () => {
       renderHook(() => useServerPaginatedDataGrid(createDefaultOptions()));
 
       expect(mockLoad).toHaveBeenCalledWith(
-        undefined, // no search term
+        '', // no search term
         expect.objectContaining({
           page: 1,
           limit: 10,
@@ -145,7 +145,7 @@ describe('useServerPaginatedDataGrid', () => {
     it('uses custom defaultPageSize in initial load', () => {
       renderHook(() => useServerPaginatedDataGrid(createDefaultOptions({ defaultPageSize: 50 })));
 
-      expect(mockLoad).toHaveBeenCalledWith(undefined, expect.objectContaining({ limit: 50 }));
+      expect(mockLoad).toHaveBeenCalledWith('', expect.objectContaining({ limit: 50 }));
     });
   });
 
@@ -299,7 +299,7 @@ describe('useServerPaginatedDataGrid', () => {
 
       // Should be called immediately, not debounced
       expect(mockRefresh).toHaveBeenCalledWith(
-        undefined,
+        '',
         expect.objectContaining({
           page: 3, // 0-indexed page 2 = API page 3
           limit: 10
@@ -355,7 +355,7 @@ describe('useServerPaginatedDataGrid', () => {
       });
 
       expect(mockRefresh).toHaveBeenCalledWith(
-        undefined,
+        '',
         expect.objectContaining({
           sort: 'updated_at',
           order: 'asc'
@@ -381,7 +381,7 @@ describe('useServerPaginatedDataGrid', () => {
 
       // Page should be preserved
       expect(mockRefresh).toHaveBeenCalledWith(
-        undefined,
+        '',
         expect.objectContaining({
           page: 3 // page 2 (0-indexed) = API page 3
         })

app/src/hooks/useServerPaginatedDataGrid.ts

@@ -10,7 +10,7 @@ import { toApiPagination } from 'utils/pagination';
  */
 export interface IUseServerPaginatedDataGridOptions<TData, TResponse> {
   /** Function to fetch data from the API */
-  fetcher: (search: string | undefined, pagination: ApiPaginationRequestOptions) => Promise<TResponse>;
+  fetcher: (search: string, pagination: ApiPaginationRequestOptions) => Promise<TResponse>;
   /** Function to extract the data array from the API response */
   extractData: (response: TResponse) => TData[];
   /** Function to extract the total count from the API response */
@@ -90,14 +90,14 @@ export const useServerPaginatedDataGrid = <TData, TResponse>(
   const [debouncedSearchTerm, setDebouncedSearchTerm] = useState('');
 
   // Data loader
-  const dataLoader = useDataLoader((search: string | undefined, pagination: ApiPaginationRequestOptions) =>
+  const dataLoader = useDataLoader((search: string, pagination: ApiPaginationRequestOptions) =>
     fetcher(search, pagination)
   );
 
   // Load data on mount
   useEffect(() => {
     const apiPagination = toApiPagination(paginationModel, sortModel);
-    dataLoader.load(debouncedSearchTerm || undefined, apiPagination);
+    dataLoader.load(debouncedSearchTerm, apiPagination);
     // eslint-disable-next-line react-hooks/exhaustive-deps
   }, []);
 
@@ -107,7 +107,7 @@ export const useServerPaginatedDataGrid = <TData, TResponse>(
     setDebouncedSearchTerm(term);
     setPaginationModel((prev) => ({ ...prev, page: 0 }));
     const apiPagination = toApiPagination(paginationModel, sortModel);
-    dataLoader.refresh(term || undefined, {
+    dataLoader.refresh(term, {
       ...apiPagination,
       page: 1
     });
@@ -127,7 +127,7 @@ export const useServerPaginatedDataGrid = <TData, TResponse>(
     (model: GridPaginationModel) => {
       setPaginationModel(model);
       const apiPagination = toApiPagination(model, sortModel);
-      dataLoader.refresh(debouncedSearchTerm || undefined, apiPagination);
+      dataLoader.refresh(debouncedSearchTerm, apiPagination);
     },
     // eslint-disable-next-line react-hooks/exhaustive-deps
     [sortModel, debouncedSearchTerm]
@@ -138,7 +138,7 @@ export const useServerPaginatedDataGrid = <TData, TResponse>(
     (model: GridSortModel) => {
       setSortModel(model);
       const apiPagination = toApiPagination(paginationModel, model);
-      dataLoader.refresh(debouncedSearchTerm || undefined, apiPagination);
+      dataLoader.refresh(debouncedSearchTerm, apiPagination);
     },
     // eslint-disable-next-line react-hooks/exhaustive-deps
     [paginationModel, debouncedSearchTerm]
@@ -147,7 +147,7 @@ export const useServerPaginatedDataGrid = <TData, TResponse>(
   // Manual refresh with current params
   const refresh = useCallback(() => {
     const apiPagination = toApiPagination(paginationModel, sortModel);
-    dataLoader.refresh(debouncedSearchTerm || undefined, apiPagination);
+    dataLoader.refresh(debouncedSearchTerm, apiPagination);
     // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [debouncedSearchTerm, paginationModel, sortModel]);
 

app/src/utils/pagination.ts

@@ -1,21 +1,12 @@
+import { GridPaginationModel, GridSortModel } from '@mui/x-data-grid';
 import { ApiPaginationRequestOptions } from 'types/pagination';
 
-export interface IDataGridPaginationModelLike {
-  page: number;
-  pageSize: number;
-}
-
-export interface IDataGridSortModelItemLike {
-  field: string;
-  sort?: 'asc' | 'desc' | null;
-}
-
 /**
  * Converts DataGrid-style pagination/sort state into API pagination options.
  */
 export const toApiPagination = (
-  paginationModel: IDataGridPaginationModelLike,
-  sortModel: ReadonlyArray<IDataGridSortModelItemLike>
+  paginationModel: GridPaginationModel,
+  sortModel: GridSortModel
 ): ApiPaginationRequestOptions => {
   const sort = sortModel[0];