Block folder public toggle override

Author: TimCsaky

app/src/controllers/bucket.js

@@ -361,9 +361,7 @@ const controller = {
         userId: userId
       };
       // Update S3 Policy
-      await storageService.updatePublic(data).catch((e) => {
-        log.warn('Failed to apply permission changes to S3 ' + e, { function: 'togglePublic', ...data });
-      });
+      await storageService.updatePublic(data);
 
       // Child bucket cannot be non-public when parent is public
       const parents = await bucketService.searchParentBuckets(bucket);

app/src/services/storage.js

@@ -562,7 +562,7 @@ const objectStorageService = {
         `coms::${resource}`.startsWith(policy.Sid) &&
         `coms::${resource}` !== policy.Sid);
       if (parentPolicy) {
-        throw new Error(`Unable to override Public status set on folder: ${parentPolicy.Resource}`);
+        return Promise.reject(new Error(`Unable to override Public status set on path: ${parentPolicy.Resource}`));
       }
     } catch (e) {
       log.debug('No existing policy found', { function: 'updatePublic' });