Block folder public toggle override

disable s3 integrity check
temporarily remove checkElevatedUser from bucket creation route

Author: TimCsaky

app/src/controllers/bucket.js

@@ -361,9 +361,7 @@ const controller = {
         userId: userId
       };
       // Update S3 Policy
-      await storageService.updatePublic(data).catch((e) => {
-        log.warn('Failed to apply permission changes to S3 ' + e, { function: 'togglePublic', ...data });
-      });
+      await storageService.updatePublic(data);
 
       // Child bucket cannot be non-public when parent is public
       const parents = await bucketService.searchParentBuckets(bucket);

app/src/routes/v1/bucket.js

@@ -21,7 +21,7 @@ router.put('/',
   express.json(),
   bucketValidator.createBucket,
   checkS3BasicAccess,
-  checkElevatedUser, // only allow elevated users to connect buckets and add folders
+  // checkElevatedUser,
   (req, res, next) => {
     bucketController.createBucket(req, res, next);
   });

app/src/services/storage.js

@@ -84,7 +84,8 @@ const objectStorageService = {
           timeout: 30000
         }
       },
-      region: region
+      region: region,
+      requestChecksumCalculation: 'WHEN_REQUIRED'
     });
     s3ClientCache.set(cacheKey, newClient);
     return newClient;
@@ -562,7 +563,7 @@ const objectStorageService = {
         `coms::${resource}`.startsWith(policy.Sid) &&
         `coms::${resource}` !== policy.Sid);
       if (parentPolicy) {
-        throw new Error(`Unable to override Public status set on folder: ${parentPolicy.Resource}`);
+        return Promise.reject(new Error(`Unable to override Public status set on path: ${parentPolicy.Resource}`));
       }
     } catch (e) {
       log.debug('No existing policy found', { function: 'updatePublic' });